AVSLab / basilisk

Astrodynamics simulation framework
https://hanspeterschaub.info/basilisk
ISC License
148 stars 61 forks source link

Equation Typo in celestialTwoBodyPoint PDF Documentation #789

Closed michaelwro closed 2 months ago

michaelwro commented 2 months ago

There's a small typo in equation 13c of the celestialTwoBodyPoint PDF documentation when compared to the SOURCE CODE. The last operation should be a cross product, not a dot product:

$$ 2 \dot{\hat{\textbf{r}}}_3 \times \dot{\hat{\textbf{r}}}_1 $$

P.S.

I came across a similar method in "Modern Spacecraft Guidance Navigation and Control" by V. Pesce and see they perform a cross product, too.

schaubh commented 2 months ago

Howdy @michaelwro , thanks for pointing this out. I'll have to find a moment to look at the original math and then ensure documentation and module are consistent.

schaubh commented 2 months ago

The typo was in 12c where there should have been a cross-product, not dot product. I checked the surrounding equations and found that equations 11 and 12 had other typos as well. The code is correct, and my original hand-written derivations were correct, but the transfer to TeX led to some typos. Thanks for pointing these out. There is a PR now awaiting approval to push an updated module documentation PDF.