search

AVSLab / basilisk

Astrodynamics simulation framework
https://hanspeterschaub.info/basilisk
ISC License
148 stars 61 forks source link

Fix incompatibility due to old versions of `packaging`. #799

Closed dpad closed 2 months ago

dpad commented 2 months ago

Description

Fixes a compatibility issue between the newer setuptools>71 (as introduced by https://github.com/AVSLab/basilisk/pull/778) and packaging<22. This is fixed by adding packaging>=22 as an additional build dependency.

Refer to https://github.com/pypa/setuptools/issues/4483 for details.

Note: this issue affects only installations in editable mode (as done by python conanfile.py). It does not affect pip install . installations.

Verification

Steps to reproduce the behavior:

  1. pip install "packaging<22"
  2. python conanfile.py
  3. See error: "TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'"

With this fix, packaging is upgraded automatically and the build works.

Documentation

Not required.

Future work

Not required.