[PE-D][Tester A] Linking does not work properly when adding an internship

When attempting to add an internship and using the optional [/l], the person is not linked to the internship.

Steps to reproduce: add -i c/some company r/some role s/accepted l/1

Output:

However, no obvious linking is displayed to the user and in the list.

IN ADDITION, providing an invalid link index is also not detected in this step. For example, if we only have up to 6 people in the persons list and adding an index of 7, no error is raised.

Relevant data file (no json attachable):

{ "persons" : [ { "personId" : 0, "name" : "Alex Yeoh", "phone" : "87438807", "email" : "alexyeoh@example.com", "internshipId" : 0, "tagged" : [ "Manager" ], "company" : null }, { "personId" : 1, "name" : "Bernice Yu", "phone" : "99272758", "email" : "berniceyu@example.com", "internshipId" : null, "tagged" : [ "Supervisor" ], "company" : "Meta" }, { "personId" : 2, "name" : "Charlotte Oliveiro", "phone" : "93210283", "email" : "charlotte@example.com", "internshipId" : null, "tagged" : [ "HR" ], "company" : null }, { "personId" : 3, "name" : "David Li", "phone" : "91031282", "email" : "lidavid@example.com", "internshipId" : null, "tagged" : [ "HR" ], "company" : null }, { "personId" : 4, "name" : "Irfan Ibrahim", "phone" : "92492021", "email" : "irfan@example.com", "internshipId" : null, "tagged" : [ "HR" ], "company" : null }, { "personId" : 5, "name" : "Roy Balakrishnan", "phone" : "92624417", "email" : "royb@example.com", "internshipId" : 1, "tagged" : [ "HR" ], "company" : null }, { "personId" : 6, "name" : "someverylongname someverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongname", "phone" : null, "email" : null, "internshipId" : null, "tagged" : [ ], "company" : null }, { "personId" : 7, "name" : "testsomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongnamesomeverylongname", "phone" : null, "email" : null, "internshipId" : null, "tagged" : [ "tag" ], "company" : null } ], "internships" : [ { "internshipId" : 0, "companyName" : "company ABC123", "internshipRole" : "frontend engineer", "internshipStatus" : "ACCEPTED", "contactPersonId" : 0, "interviewDate" : "No interviews scheduled" }, { "internshipId" : 1, "companyName" : "Google", "internshipRole" : "data analyst", "internshipStatus" : "PENDING", "contactPersonId" : 5, "interviewDate" : "2022-11-11 11:11" }, { "internshipId" : 2, "companyName" : "test", "internshipRole" : "test test", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2020-12-20 12:00" }, { "internshipId" : 3, "companyName" : "Grab", "internshipRole" : "Full Stack Developer", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2000-02-28 12:00" }, { "internshipId" : 5, "companyName" : "Grab2", "internshipRole" : "Full Stack Developer", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2000-02-29 12:00" }, { "internshipId" : 7, "companyName" : "Grab3", "internshipRole" : "Full Stack Developer", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2001-02-28 12:00" }, { "internshipId" : 8, "companyName" : "Grab4", "internshipRole" : "Full Stack Developer", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2001-02-28 12:00" }, { "internshipId" : 9, "companyName" : "Grab5", "internshipRole" : "Full Stack Developer", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2020-02-29 12:00" }, { "internshipId" : 11, "companyName" : "Grab6", "internshipRole" : "Full Stack Developer", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "2001-02-28 12:00" }, { "internshipId" : 12, "companyName" : "test", "internshipRole" : "test2", "internshipStatus" : "ACCEPTED", "contactPersonId" : null, "interviewDate" : "No interviews scheduled" }, { "internshipId" : 13, "companyName" : "test2", "internshipRole" : "test", "internshipStatus" : "COMPLETED", "contactPersonId" : null, "interviewDate" : "No interviews scheduled" }, { "internshipId" : 14, "companyName" : "testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttest", "internshipRole" : "testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttest", "internshipStatus" : "PENDING", "contactPersonId" : null, "interviewDate" : "No interviews scheduled" }, { "internshipId" : 15, "companyName" : "some company", "internshipRole" : "some role", "internshipStatus" : "ACCEPTED", "contactPersonId" : null, "interviewDate" : "No interviews scheduled" } ] }

Labels: severity.Medium type.FunctionalityBug original: Ferusel/ped#10

AY2223S1-CS2103T-F11-1 / tp

[PE-D][Tester A] Linking does not work properly when adding an internship #227