search

AY2425S1-CS2103-F09-1 / tp

MIT License
0 stars 5 forks source link

[PE-D][Tester D] UML Model diagram may be incorrect #279

Closed soc-se-bot closed 2 weeks ago

soc-se-bot commented 3 weeks ago

image.png

Nickname is an optional field, but in this case, but from the diagram it is compulsory field? Should it be 0...1? Unless it is initialised with an empty string

Labels: severity.Medium type.DocumentationBug original: slye20/ped#6

somethingfishyfishy commented 2 weeks ago

To state in DG that empty Nickname is stored as an empty string

wuzengfu commented 2 weeks ago

To state in DG that empty Nickname is stored as an empty string

I think we can take no action against this issue and close it. Could not find a good place to add in this details. And this is the expected behavior since our code implementation always creates a Nickname instance even though the nickname is empty. So, the cardinality is supposed to be 1.