search

Aagam-Jain-113 / AidZee

In this project, we bring everyone around us closer, but virtually by creating a place where anyone can post about anything, and people around them will help. So, feeling lonely and want someone to talk or need some help. Hit up AidZee!
GNU General Public License v3.0
1 stars 1 forks source link

Add Loader #17

Closed thesauravkarmakar closed 4 years ago

thesauravkarmakar commented 4 years ago

After we click the Public Room Button, we should get Location Access popup, until the person Allows it there should we a Loader something like this https://codepen.io/dctdevelop/pen/WbqbLb. After it is allowed then the page should open.

saurabhshalu commented 4 years ago

Kindly add hacktoberfest topic to the project too. It's only hactoberfest2020 is mentioned. Due to that I lost my 1 PR> :(

If you fix that, I'll work on this issue too.

thesauravkarmakar commented 4 years ago

Kindly add hacktoberfest topic to the project too. It's only hactoberfest2020 is mentioned. Due to that I lost my 1 PR> :(

If you fix that, I'll work on this issue too.

I have done that. Please look into that!

image

saurabhshalu commented 4 years ago

You can assign me to this task. I'll try to improve it.

What screen you want if user denied to give the location access?

Just the console log will be fine as it was in my last PR?

thesauravkarmakar commented 4 years ago

You can give some Pop-Up Error showing 'Until Location Access isn't given he/she can't move to Public Room.'

Assigning to you, @saurabhshalu

thesauravkarmakar commented 4 years ago

Solved #19