Aang23 / UndergroundBiomesConstructs

Underground Biomes Constructs for Minecraft 1.12.2 / 1.13.2
Other
12 stars 15 forks source link

[1.12.2] Non consistent (lack of) decoration replacement with different stone generators #240

Open Foreck1 opened 4 years ago

Foreck1 commented 4 years ago

There's currently a major limitation when it comes to underground blocks replacement and biomes

In my current setup I'm using Gave Generator to attempt generating "realistic" layers of strata loosely based on the geology of Earth. Ore stone variants replaces all stone generation as expected, but UBC fails to change other blocks like gravel, sand and overgrown stone to match the corresponding layer, causing a visual disconnection in terrain generation, as well as spawning thematically inconsistent variants of rocks.

image

in short: Ground layers, gravel and sand are still following the UBC's seeds independently of what stone CG generates.

I'm happy to provide and files or logs necessary to come up with a solution. Thanks for your time.

Foreck1 commented 4 years ago

Probably related to https://github.com/Aang23/UndergroundBiomesConstructs/issues/48

Morketh commented 4 years ago

Flat world gen has ore pockets as far as i understand how the flat world gen works i should be looking at a 20 block thick slab of marble sitting on top of 1 block of bedrock. we do infact have a 20 marble thick on 1 bedrock but im not sure the ore is supposed to be included unless specified on the gen parameter string 3;minecraft:bedrock,20*undergroundbiomes:metamorphic_stone:2 image image

LemADEC commented 2 years ago

You can't have vanilla or another mod doing the stone placement while UndergroundBiomes does the ore replacement.
If you want a custom tone generation, then you need to disable the mod in that dimension (just using it to get the block variations) and use another to generate ores while respecting the current stone at that location.
CoFH world can do that for you, through it's a bit tedious to duplicate for all stone variations.

In the long term, we could imagine more customization to stone generation in this mod, or adding custom ore generation. None of those are planned at this time.