Aang23 / UndergroundBiomesConstructs

Underground Biomes Constructs for Minecraft 1.12.2 / 1.13.2
Other
12 stars 15 forks source link

Fixed compatibility with others mods, notably GTCEu #247

Open LemADEC opened 2 years ago

LemADEC commented 2 years ago

Advanced mods actively use the target predicate in isReplaceableOreGen(). Since UBC ignores it and returns hardcoded values, this breaks compatibility with such mods like GTCEu. This merge request address this by actually evaluating the predicate against vanilla equivalent block, allowing to integrate with other mods without having them to declare or support UBC variants.

When placing ore veins using a MutableBlockPos, UBC fails to ubify all ores due to invalid assumption on the permanent state of the passed object. This is clearly visible with GTCEu when only 1 ore per layer per vein is actually ubified. This merge request fixes that issue with the related vanilla API.

A few deadcode locations have been cleaned up too.

I've made a GTCEu configuration file but I've no intention to reimplement it in the mod. Ping me if you want that file for your own modpack or would like to implement it in the mod, or whatnot.