AaronFeng753 / Waifu2x-Extension-GUI

Video, Image and GIF upscale/enlarge(Super-Resolution) and Video frame interpolation. Achieved with Waifu2x, Real-ESRGAN, Real-CUGAN, RTX Video Super Resolution VSR, SRMD, RealSR, Anime4K, RIFE, IFRNet, CAIN, DAIN, and ACNet.
https://patreon.com/aaronfeng
Other
13.2k stars 884 forks source link

[BUG] "Keep subtitles" option makes broken video when there is 2 subtitles in source. #523

Closed randomizer2223 closed 11 months ago

randomizer2223 commented 1 year ago

Software Version Latest Stable Checked on v3.101.01 and just rechecked on v3.102.01 [Premium]

Describe the bug When using option "Keep subtitles" with video file that contains 2 subtitles options inside: then *.MKV video file appear corrupted, it is impossible to play it longer then 2 minutes.

Without "Keep subtitles" *.MKV video file is ok.

How to Reproduce the bug Steps to reproduce the bug: 1) Download video file:

Expected behavior 5) Video will not crash.

Again: if do not use "Keep subtitles" but still use MKV - all converted perfect. So issue seem to be with "Keep subtitles" option.

Screenshots Crash looks like this in some players: Screenshot_1 In some it just stops playing.

Files you were trying to process when encountered the BUG

The settings you were using when issue occurred settings.zip

Desktop (please complete the following information):

AaronFeng753 commented 1 year ago

Thank you for your report, definitely will look into this

AaronFeng753 commented 1 year ago

I was able to reproduce this bug, but only on this video you sent me, I can't reproduce this bug using other videos which also have multiple subtitles and audio streams

Does this only happen to one series of videos? Like does it only happens when you upscaling videos you get from this source or other videos also have this issue

randomizer2223 commented 1 year ago

Hi, I have such issues with other titles, literally 7 of 20 video titles I am trying to convert have this issue.

Maybe it is because of special language in subtitles, as it has some special letters like: Ґ, ґ (https://www.compart.com/en/unicode/U+0491) e.t.c.

Here is one more video file with same issue: https://mega.nz/file/oa811CyC#y26F6nhkMeb-ZGbcVqgXG_BBEJuexkWoUeDM3halQ7s

It's not a big issue, i am recreating subtitles manually by hands. (Thought it takes time... And I do not always know in advance if video will corrupt or not...) But I will appreciate if some time it can be fixed.

In any case: Thank you for this wonderful tool!

AaronFeng753 commented 1 year ago

My question is, is all videos you have which has 2+ subtitles have this issue, or only a few of them have this issue

I also agree language could be part of the cause, since I only have videos with English subs and they don't have this issue

randomizer2223 commented 1 year ago

Hi, not all videos. Some videos that have 2+ subtitles have this issue, but not all of them.

For videos I am using it is approximately 30% (Already have issue with 7 titles among 20) If fix is not obvious, maybe it is good to put it aside, and wait till anyone expect me will face this issue.

EugenePoubel commented 1 year ago

i have the same issue with file

https://mega.nz/file/HYNG3RYD#_OR1OlNBiretyS7pT5lSpyz-Nfjp3hNkOfLQpOdQWc0

AaronFeng753 commented 11 months ago

✅Fixed, please wait for next update

2023-12-12_13-36-11

@randomizer2223 @EugenePoubel

AaronFeng753 commented 11 months ago

✅ Fixed in v3.108.18-beta and later vers