search

Abhijeet-AR / Competitive_Programming_Score_API

API to get user details for competitive coding platforms - Codeforces, Codechef, SPOJ, Interviewbit
MIT License
183 stars 59 forks source link

Added atcoder support #17

Closed sainad2222 closed 3 years ago

sainad2222 commented 3 years ago

added atcoder to api json fields: rating highest(highest rating) rank level

Abhijeet-AR commented 3 years ago

Everything's fine when tested in local environment

Thanks for the PR @sainad2222. I found a couple of issues, let's fix it and merge.

One question I have is, what is BrokenChangesError? Do we need it? If we need it, let's handle the error too in main.py similar to the other errors.

sainad2222 commented 3 years ago

Regarding BrokenChangesError if there are some broken changes like change in UI or selector during site updates that may break code. I now added code to handle this exception and also added table issue in try block. Let me know if any changes needed. Thanks for API :)

If you feel like the name BrokenChangesError is not relevant feel free to suggest new name. I'll change accordingly. I feel like it's necessary to handle these type of exceptions too

Abhijeet-AR commented 3 years ago

You forgot to import BrokenChangesError in main.py.

Abhijeet-AR commented 3 years ago

Regarding BrokenChangesError if there are some broken changes like change in UI or selector during site updates that may break code. I now added code to handle this exception and also added table issue in try block. Let me know if any changes needed. Thanks for API :)

If you feel like the name BrokenChangesError is not relevant feel free to suggest new name. I'll change accordingly. I feel like it's necessary to handle these type of exceptions too

Yeah, that's a good idea. Completely makes sense.

sainad2222 commented 3 years ago

I tested once again locally. Looks fine to me. Let me know if any changes needed