search

Abjad / abjad

Abjad is a Python API for building LilyPond files. Use Abjad to make PDFs of music notation.
https://abjad.github.io
GNU General Public License v3.0
239 stars 39 forks source link

abjad-book Sphinx extension should halt building on image-generation failure #184

Closed trevorbaca closed 9 years ago

trevorbaca commented 10 years ago

From josiah.oberholtzer on December 09, 2012 10:38:17

The abjad-book Sphinx extension uses a process pool to handle generating all images. Should an image fail to generate for whatever reason - usually because the Abjad object cannot be formatted, or because the resulting formatted object results in bad LilyPond code - the error is not reported, and does not cause the sphinx-build process to halt. This makes it difficult to determine where an error occurred.

Instead, failed images should fail the API page where they occur, and force the build to halt, as though they were an ReST syntax error.

Original issue: http://code.google.com/p/abjad/issues/detail?id=183

josiah-wolf-oberholtzer commented 9 years ago

Failed rendering does not cause the entire Sphinx build process to fail. That was actually a big problem, requiring a complete re-read and re-write. Now failed renderings are reported, but are not catastrophic.

trevorbaca commented 9 years ago

Incredibly better than the complete destruction we had before ;)