AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
40 stars 35 forks source link

[1.12.2] anamiation of open doors is broken #210

Closed Skaphegor closed 6 years ago

Skaphegor commented 6 years ago

Maybe I am wrong but I the 1.7.10 version the doors could be opened. In the 1.12.2 version they always show up the same texture.

This door is closed. 2017-12-21_17 40 46

and this door is open 2017-12-21_17 40 48

Is that intended or a bug?

Wyn-Price commented 6 years ago

That isnt good! Could you place a door on a normal area, without blocks by it, and screenshot it. Also, are you using Optifine.

Wyn-Price commented 6 years ago

Also what version of the one probe are you using. There should be support for that.

Skaphegor commented 6 years ago

OptiFine 1.12.2 HD U C7

That is not the OneProbe. It is HWLYA. https://minecraft.curseforge.com/projects/hwyla

What do you mean with normal area? How could I place the door if there is no ground beneath?

Wyn-Price commented 6 years ago

Ah yes this is an issue with C7. Currently c7 source code isnt released. So Im not able to make it work fully. C6 works perfectly though. Ill add a check to see if if the version of Optifine is correct

Wyn-Price commented 6 years ago

If you look in the logs, it should be spamming you with warnings?

Skaphegor commented 6 years ago

2017-12-21-4.log.gz You mean something like that?

Skaphegor commented 6 years ago

That is the latest one.

Skaphegor commented 6 years ago

I took a picture of that without Optifine. It seems that Optifine is not resposible for the behavior. 2017-12-30_10 29 22 2017-12-30_10 29 30

Wyn-Price commented 6 years ago

Ok that's interesting.ill look more into it. I'm busy at the moment so I don't know if I'll be able to do it soon

Wyn-Price commented 6 years ago

Could you send me the latest.log after playing this world, without optifine

Skaphegor commented 6 years ago

2017-12-30-1.log.gz

Wyn-Price commented 6 years ago

There should be a file called latest.log, not in a .gz file. Could you play the test world, then send me that file

Skaphegor commented 6 years ago

latest.log

Wyn-Price commented 6 years ago

Ok I'm free in around an hour so I'll be able to look into it then.

Skaphegor commented 6 years ago

You can upload a file if you need it to get tested.

Wyn-Price commented 6 years ago

Yeh that would be probably something I need to do

Wyn-Price commented 6 years ago

Im unable to replicate this without using Optifine C7. Are you sure youre not using that

Skaphegor commented 6 years ago

I am pretty sure I removed it. I will test it again.

Skaphegor commented 6 years ago

Seems that I was extremely confused. However, if Optifine C 6 is installed everything works fine. Only C 7 seems to be bugged.

Wyn-Price commented 6 years ago

Ok that makes sense. Im working on a fix for C7 at the moment

Skaphegor commented 6 years ago

fixed in 5.1.13

Wyn-Price commented 6 years ago

Glad it finally was fixed. Sorry I took so long, it was hard to find a way to manipulate Optifine in a way so this would work