AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
40 stars 35 forks source link

WALIA/HWYLA Intergration for packs/players who don't use The One Probe. #226

Closed KiriCattus closed 6 years ago

KiriCattus commented 6 years ago

Optifine?: No. If so what version: N/A. Does adding/removing Optifine affect the issue?: N/A.

This is a request for HWYLA integration for the mod as more packs use this mod and without it, the blocks show what they are in HWYLA.

HWYLA A fork of WAILA maintained by TehNut.

Wyn-Price commented 6 years ago

Sure! Im currently working on a new MC rendering system for this, and other mods, but after then sure

Wyn-Price commented 6 years ago

OK finished up new rendering system. Working on this now

KiriCattus commented 6 years ago

Nice I look forward to it. Currently putting together a pack update for later tonight/tomorrow but might this be done before next weekend? Don't mind the wait for something to be done right 👍

Wyn-Price commented 6 years ago

Probally will be done either today or in the next few days. Shouldn't be hard to do

KiriCattus commented 6 years ago

Cool I'll keep an eye out for it. Good luck and thanks in advance!

Wyn-Price commented 6 years ago

Are you able to test this

KiriCattus commented 6 years ago

Testing now

Wyn-Price commented 6 years ago

Thanks!

KiriCattus commented 6 years ago

1st issue: when a lever is placed on a log (Oak Wood in this case) it shows up as "Wood" rather than Oak Wood Same for all other wood types so far but the texture changes as it should to the log type.

Turns out this happens with anything placeable in the world

KiriCattus commented 6 years ago

Torch Lever has no image next to the info from HWYLA but does show it's name as Torch Lever I guess as intended?

Wyn-Price commented 6 years ago

Ok this should fix the wood issue

Wyn-Price commented 6 years ago

Ill look into the Torch Lever thing now

Wyn-Price commented 6 years ago

Ah thats an issue with HWYLA. It happens with alot of blocks.

image

image

Wyn-Price commented 6 years ago

I can actually fix this I think

KiriCattus commented 6 years ago

I did just ask @TehNut but he thinks it's an issue with another mod I have installed (WAILA an addon mod)

Wyn-Price commented 6 years ago

I have a clean version of HWYLA/WAILA, with the only addon being mine

KiriCattus commented 6 years ago

Same thing on my end

Wyn-Price commented 6 years ago

It occured in the original 1.7.10 versions i do belive, its todo with the face that the block dosnt have an item attached to it.

Wyn-Price commented 6 years ago

one thing i have noticed: image image

TehNut commented 6 years ago

This was solved in one of my many bugfixes. May I see your plugin?

KiriCattus commented 6 years ago

I shall ask Darkhax now should have a reply in a few min

Wyn-Price commented 6 years ago

@TehNut problem solved. Was an issue on my side image image image

KiriCattus commented 6 years ago

Herp Derp lol

KiriCattus commented 6 years ago

2018-02-18_22 57 18 2018-02-18_22 57 23

Might have noticed another issue not relating to any of this with grass textures being identical rather than the random look of vanilla grass but so far everything else works fine (Bar the texture bug in hwyla's box you just found on your end)

Wyn-Price commented 6 years ago

Yeah the grass is currenly acting strange with AO. I think i figured out why, just gotta work on a fix

Wyn-Price commented 6 years ago

heres latest version. Should be HWYLA/WAILA bug free

KiriCattus commented 6 years ago

Will give it a final test through now

KiriCattus commented 6 years ago

All works great now Thanks!

Wyn-Price commented 6 years ago

Alright. Ill work on some bugs and that AO issue, and ill release a new version either later today or tommorow. Thanks for the help!