search

AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
40 stars 35 forks source link

SRM 5.6.0 breaks trapdoor rendering #242

Closed brisingraerowing closed 6 years ago

brisingraerowing commented 6 years ago

Optifine?: No If so what version: N/A Does adding/removing Optifine affect the issue?: Not Tested (Incompatible with other mods)

SRM v5.6.0 causes wooden trapdoors to render invisible. Reverting to 5.5.5 makes them visible again.

Wyn-Price commented 6 years ago

What mods are you using? In dev it renders

brisingraerowing commented 6 years ago

I'll test my mods and see what's going on.

brisingraerowing commented 6 years ago

It appears to be a bug with the Malisis Doors compat, as an instance with SRM, Malisis Doors, and Malisis Core exhibits the behavior.

Wyn-Price commented 6 years ago

Malisisdoors support is the one thing 5.6.0 sorted out. It works on my end. What version of forge are you using, I might need to update

brisingraerowing commented 6 years ago

I was using 2631, as Dynamic Surroundings would crash with newer versions. An update to DS that fixes that is available, so I'm updating to 2640. I'll see if the newer Forge works or not.

EDIT: Still broken in 2640.

Wyn-Price commented 6 years ago

@BrisingrAerowing Ok ill look into versions 2631+. I dont know if ill have time to do it in the next week or so, as i modjam is on tommorow and im participating in it. Ill look into it tonight but if i cant find a fix itll have to wait. I dont want any underlying problems while modjams going on

Wyn-Price commented 6 years ago

@BrisingrAerowing is this issue still occuring in 5.6.1?

brisingraerowing commented 6 years ago

Yes.

Wyn-Price commented 6 years ago

Is this fixed in 5.6.2? Version should be on curse in an hour or 2

brisingraerowing commented 6 years ago

I’ll check when I get back to my computer.

brisingraerowing commented 6 years ago

Unfortunately not fixed yet.

Wyn-Price commented 6 years ago

Are you running srm on its own? or are there other mods apart from malisisdoors

brisingraerowing commented 6 years ago

Other mods, but a test with just SRM and Malisis Doors showed the issue as well.

ate0ate commented 6 years ago

Yeah, I can confirm that this is happening using just the recommended version of forge (2655), most recent Malisis Core/Doors (6.4.0/7.3.0), and Secret Rooms 5.6.2. Its been quite a while since I've seen a trapdoor lol.

Wyn-Price commented 6 years ago

Ok. I won't be able to look into it until Friday, as I have exams leading up until then. But after exams, I'll figure out what's going on

Wyn-Price commented 6 years ago

Ok, exams ended. I'll either look into it today or tomorrow

ate0ate commented 6 years ago

Sorry I didn't respond sooner, but after putting it through its paces everything seems to be working just fine since updating. Thanks a bunch for the fix. I've got almost 300 mods in my pack and optifine so if it works well there it should be good anywhere lol.

MastaC729 commented 5 years ago

Ugh, I hate to stir this up but I'm having the issue again on version 5.6.4 of SRM. Here are the versions installed:

SRM: 5.6.4 MalisisDoors/Core: 7.3.0 MalisisCore: 6.4.0 Forge: 14.23.5.2796