search

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.8k stars 458 forks source link

Improve Lut3D GPU unit test to not create temporary files #2017

Closed doug-walker closed 1 month ago

doug-walker commented 3 months ago

The module: OpenColorIO/tests/gpu/Lut3DOp_test.cpp, uses a function createTempFile to execute some tests with various test LUTs. These are not later cleaned up. These LUTs could be added to the test file directory and read from there so that no temp files are created. The createTempFile function could then be removed.

ananthb commented 2 months ago

I'll tackle this in the upcoming dev days event.

carolalynn commented 2 months ago

Sounds great, @ananthb - looking forward to having you participate! Please reach out on slack and say hello, or if you have any questions!

ananthb commented 2 months ago

Will do.

carolalynn commented 1 month ago

Hi @ananthb - just wanted to do a quick follow-up and see if you are still planning on tackling this issue? We'd love to have you participate - but either way, just let us know! :)

ananthb commented 1 month ago

I was a bit held up on the actual day of, but I'm working on it right now actually. I should be able to get some code across very soon.

carolalynn commented 1 month ago

No problem, sounds great! Feel free to reach out if you've got questions on slack.