search

AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
401 stars 17 forks source link

Default value of transmission_dispersion_abbe_number is not between uisoftmin and uisoftmax #200

Open JGamache-autodesk opened 1 month ago

JGamache-autodesk commented 1 month ago

The soft min and max of that parameter are between 9.0 and 91.0, yet the default value is 0.0. I would have expected the default value to sit between the soft min and max (for UI purpose).

jstone-lucasfilm commented 1 month ago

Good catch, @JGamache-autodesk, and I believe this is simply a bug that should be addressed for v1.0.

I'm CC'ing @peterkutz and @portsmouth for confirmation, but I believe the intended default for this parameter is 20.0.

portsmouth commented 1 month ago

Yes it should be 20.