AcademySoftwareFoundation / openfx

OpenFX effects API
Other
421 stars 124 forks source link

Update the ColourSpace example #170

Closed Guido-assim closed 1 month ago

Guido-assim commented 2 months ago

Do not set kOfxImageClipPropPreferredColourspaces for the output clip. Handle kOfxImageEffectActionGetOutputColourspace to set the output colourspace.

garyo commented 2 months ago

One small but important thing: please add a "DCO" line to your commit message. I suggest doing it by amending the latest commit and force-pushing, like this:

# make sure you're at commit ca59362 before starting this, with no changes, and then:
git commit --amend
# in your editor, add a blank line, and then "Signed-off-by: Guido Veldkamp <guido.veldkamp@assimilateinc.com>", then save.
git push -f # force-push your branch; this will update the PR automatically

In future, just use git commit -s instead of git commit to automatically add the "Signed-off-by" line.

john-paulsmith commented 1 month ago

Thanks for improving the example @Guido-assim, I'm going to merge it. This example doesn't do anything with the host-provided preferred output colourspace list, it would be good to include that in a future example.