Acidham / chromium-hist-bookmarks

Search in Chromium History and Bookmarks
137 stars 18 forks source link

Add python3 wrapper. fixes #5 #6

Closed avielsh closed 4 years ago

avielsh commented 4 years ago

Added a python wrapper. The wrapper check for known paths and selects the latest python3 version found. (configurable) a py3 file is written inside the script directory after initial setup for faster execution. On configuration change/error in python, the script will reinitialize the python3 path.

Acidham commented 4 years ago

Thanks for the wrapper! One suggestion: The py3 file is stored in workflow directory better would be to save this config file locally in alfred_workflow_data (https://www.alfredapp.com/help/workflows/script-environment-variables/)

The reason is, when you run the workflow on different machines with slightly different python set up the WF would fail on one or the other machine.

avielsh commented 4 years ago

Thanks for the wrapper! One suggestion: The py3 file is stored in workflow directory better would be to save this config file locally in alfred_workflow_data (https://www.alfredapp.com/help/workflows/script-environment-variables/)

Sure , I'll change it when I get near a pc...

P.S I've double checked on default HighSierra and Mojave clean installs and python3 does not reside on /usr/bin so this wrapper is good for smthin..

Acidham commented 4 years ago

wrapper is great! I will add it to my other python3 workflows! Looking forward for storing in alfred_workflow_data PR ;)

Acidham commented 4 years ago

Changed py3 file creation in alfred_workflow_data

Acidham commented 4 years ago

https://github.com/Acidham/chromium-hist-bookmarks/releases/tag/v2.1.6

avielsh commented 4 years ago

I see you already implemented alfred_workflow_data. Kudus... But I think you have merged the original pull request 5bf4c47... instead you should merge cad4aef which includes a bunch of bug fixes, code cleanup and comments that were added later on..

avielsh commented 4 years ago

Yep, It looks good now 👏