search

AckerApple / agm-overlays

Custom marker overlay for the @agm/core package
MIT License
25 stars 24 forks source link

Update position of overlay #18

Closed jvv closed 5 years ago

jvv commented 5 years ago

Hi, I saw issue #4 after I encountered the same problem. I'm currently on latest (1.3.0) on which the same issue seems to be happening. In the 1.1.2 version the location can be updated indeed.

core.js:1449 ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'addEventListener' of undefined TypeError: Cannot read property 'addEventListener' of undefined at AgmOverlay.getOverlay (AgmOverlay.component.js:134) at eval (AgmOverlay.component.js:70) at ZoneDelegate.invoke (zone.js:388) at Object.onInvoke (core.js:4760) at ZoneDelegate.invoke (zone.js:387) at Zone.run (zone.js:138) at eval (zone.js:872) at ZoneDelegate.invokeTask (zone.js:421) at Object.onInvokeTask (core.js:4751) at ZoneDelegate.invokeTask (zone.js:420) at AgmOverlay.getOverlay (AgmOverlay.component.js:134) at eval (AgmOverlay.component.js:70) at ZoneDelegate.invoke (zone.js:388) at Object.onInvoke (core.js:4760) at ZoneDelegate.invoke (zone.js:387) at Zone.run (zone.js:138) at eval (zone.js:872) at ZoneDelegate.invokeTask (zone.js:421) at Object.onInvokeTask (core.js:4751) at ZoneDelegate.invokeTask (zone.js:420) at resolvePromise (zone.js:814) at eval (zone.js:724) at eval (zone.js:740) at ZoneDelegate.invoke (zone.js:388) at Object.onInvoke (core.js:4760) at ZoneDelegate.invoke (zone.js:387) at Zone.run (zone.js:138) at eval (zone.js:872) at ZoneDelegate.invokeTask (zone.js:421) at Object.onInvokeTask (core.js:4751)

AckerApple commented 5 years ago

Thank you. This is an important item. However, at this time the demo is working to update marker positions. That first makes me question your configuration BUT you sure have done some homework on the issue so I doubt you config'd wrong.

Hmmmmmmmmm. We track the locations of caregivers at my job where this package is used in production. I have also not received reports.

I will try to look into this more.... The "addEventListener" is a basic attachment process so I would think this kind of failure would have attracted more issue reports.

Hmmmmmmmm. Not sure at this moment where the issue is

AckerApple commented 5 years ago

Ah, I see although the demo does update position it does throw an error. I can tackle this then.

Just a matter of having the time.

Will report more when I can

jvv commented 5 years ago

So a bit more information on the project im playing with :) perhaps it helps.

I have the maps / the cluster and a bunch of markers on the map (markers through agm-overlays). The marker I'd lile the position to be changed is the "my location" marker, for which the lat/lng can be obtained through either the navigator.geolocation or through a geocode lookup.

The first request always succeeds / the second (and third etc.) results in the error in initial message.

Template: `<agm-overlay *ngIf="geoService.user_lat" [latitude]="geoService.user_lat" [longitude]="geoService.user_lng">

</agm-overlay>`

and I basically just set/overwrite the user_lat and user_lng.

If any more info would help please let me know :)

AckerApple commented 5 years ago

I'm glad you came up with the full rewrite of position to get by.

I am scheduled to work on this issue Thursday afternoon

AckerApple commented 5 years ago

Please acquire version 1.3.1, test and close if satisfied

jvv commented 5 years ago

Thanks @AckerApple - it's working now.