search

AckerApple / agm-overlays

Custom marker overlay for the @agm/core package
MIT License
25 stars 24 forks source link

[Error - readme] Bounds #20

Closed rbalet closed 5 years ago

rbalet commented 5 years ago

Incorrect bounds attribute into the readme

(Not sure about that) The bounds attribute should be in the agm-overlay instead of the agm-map

AckerApple commented 5 years ago

Not sure to what you are referencing. Could you help further and elaborate.

Thank you kindly for being helpful

rbalet commented 5 years ago

For sure, sorry for the unclarity.

Like the example you linked, this bounds should be within the agm-overlay image

(On the left the code I found in your readme, on the right, how it should be)

I take for example the code found into agm-overlays/example/src/app.template.ts image

I'm not 100% sure about what I say, but using the bounds attribute within the agm-map led me to errors

AckerApple commented 5 years ago

I much appreciate you bringing this to my attention. I have adjusted the README.md but have NOT republished to npm yet. With the next release, the README.md will be updated everywhere and not just Github.

Special request, I like to remember those I work with plus for many other great reasons, please consider my request of you to have legit Github icon of yourself.

Be well. Feel free to contact me about this or any of my packages or if you happen to play a really great pinball machine. I love pinball

unadjustednonraw_thumb_dca

rbalet commented 5 years ago

Well, I gonna do that ;)

I then close this issue, thanks a lot for this plugin.