search

AckerApple / agm-overlays

Custom marker overlay for the @agm/core package
MIT License
25 stars 24 forks source link

Remove invisible marker that's blocking hover styles #25

Closed clpalmer closed 5 years ago

clpalmer commented 5 years ago

As per the closed issue #24 here's a PR describing exactly the change I need. As you can see from the screenshot, the AGM marker that's created causes a 40px transparent image to be inserted in the DOM at a higher z-index than my custom overlay so my custom overlay can no longer receive hover events. This PR just sets the visibility of that dummy AGM marker to false so it won't render the unnecessary transparent image.

image

AckerApple commented 5 years ago

Very interesting and I now mostly understand.

The knowledge I was missing and hope I’m right on, is the agm-core or the custom overlay library used in this package, has a transparent placeholder image of sorts. And your pull request is to set that invisible marker to default invisible in essence.

This pull request and it’s exact details are very much appreciated. I can work with this.

I have promised another pull request my time this week and so too will I test and run this through.

Thanks good person, great to be finding a level we can get things done on

clpalmer commented 5 years ago

Yes, your understanding is correct.

There is a 40px transparent image (because of the " " set as iconUrl) that is rendered over top of the agm-overlay and is rendered in the DOM in a separate place with a separate zindex that forces it above the overlay and blocks hover.

And, as you said, this PR just disables the marker that causes it.

AckerApple commented 5 years ago

Ah, I appreciate you reiterating what you said especially about the iconUrl as I'd like to look into the how/why it's default set to that (I believe it was to fight extending agm-core marker directive)

I'll check it out relatively soon.