ActianCorp / actian_tableau_connector

Tableau connector (aka taco) for Actian Avalanche, Vector, and Ingres
https://extensiongallery.tableau.com/products/936
Apache License 2.0
1 stars 4 forks source link

Fix string.contains tests II-12244, II-12245, II-12500 #42

Closed hab6 closed 11 months ago

hab6 commented 11 months ago

Summary

Change of formula in Actian dialect CONTAINS function fixes failures for several string.contains test cases.

Jira Ticket Test Cases Before Fix After Fix
II-12244 CONTAINS([str1], Null)
CONTAINS([str2], Null)
FAIL PASS
II-12245 CONTAINS(str2, "A(")
CONTAINS(str2, "A(")
FAIL PASS
II-12500 CONTAINS(str2, "e")
CONTAINS(str1, "IND")
FAIL PASS

Full TDVT Suite Test Results

Tests Before Fix After Fix
Pass 850 854
Fail 20 14
Total 868 868

test_results_combined-BASELINE000.csv test_results_combined-BEFOREFIX.csv test_results_combined-AFTERFIX.csv

Update

I mistakenly left issue II-12500 off the initial post of this PR even though the issue was in fact also fixed by this PR.

There are now 3 CSV results files attached above.