ActiveState / OpenKomodoIDE

Open Komodo IDE is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
Other
576 stars 135 forks source link

OSX Build Error: OSError: error running 'unzip -q -d macosx macosx.zip': 9 #5

Open justquick opened 1 year ago

justquick commented 1 year ago

When following the readme's instructions to build on my mac i get an error during build.py configure where it is unable to unzip the prebuilt zip because the files seem to be git LFS pointers. The readme does not mention any lfs requirement or steps to download those zipfiles. How can I download those zipfiles so I can build komodo?

Steps to reproduce

Exception

target: configure
/bin/sh: svnversion: command not found
build: warning: Failed to get changenum, using 0 instead
unzipping prebuilt python in `prebuilt/python2.7/macosx'
[macosx.zip]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of macosx.zip or
        macosx.zip.zip, and cannot find macosx.zip.ZIP, period.
Traceback (most recent call last):
  File "build.py", line 2910, in <module>
    sys.exit( main(sys.argv) )
  File "build.py", line 2906, in main
    return build(args)
  File "build.py", line 2730, in build
    newArgv = targetFunc(argv)
  File "build.py", line 1297, in target_configure
    dirname(prebuiltDir), log.debug)
  File "build.py", line 214, in _run_in_dir
    _run(cmd, logstream=None)
  File "build.py", line 196, in _run
    raise OSError("error running '%s': %r" % (cmd, status))
OSError: error running 'unzip -q -d macosx macosx.zip': 9
th3coop commented 1 year ago

This is due to me, last minute, setting up git LFS to accommodate the Komodo installers. I'd suggest either opening a PR to remove anything but the installers directory from LFS or Googling how to have Git pull down LFS files, and if you're feeling up for it, opening a PR to update the README with those instructions. But I think removing unnecessary files from LFS is probably the better idea.

justquick commented 1 year ago

what about using github releases? having the installers available to download instead of building it myself if possible seems like an ideal way to get up and running quickly

AhmedEzzat12 commented 1 year ago

what about using github releases? having the installers available to download instead of building it myself if possible seems like an ideal way to get up and running quickly

I second that!

th3coop commented 1 year ago

Oh that's a great idea, @justquick. Just fyi, you don't need to build anything. The installers in the installers directory can be downloaded right now and run. I'll move those to a release soon.

th3coop commented 1 year ago

@justquick any chance you can checkout th3oop/remove-installers-disable-git-lfs and see if you still get the error? I'm having a hell of a time untangling git lfs from the repo. What a nightmare that tool is.

FYI, I created a release for IDE: https://github.com/ActiveState/OpenKomodoIDE/releases/tag/12.0.1 and Edit: https://github.com/komodo/KomodoEdit/releases/tag/12.0.1