ActivitySim / activitysim

An Open Platform for Activity-Based Travel Modeling
https://activitysim.github.io
BSD 3-Clause "New" or "Revised" License
194 stars 99 forks source link

Write Trip Matrices Relies on Duplicated Time Period Specifications #373

Open danielsclint opened 3 years ago

danielsclint commented 3 years ago

The write trip matrices methods should use the time period definitions included in the network LOS. The current implementation relies on time period labels being defined in the write_matrices.yaml outside of the time definitions in the network_los.yaml used by the rest of the model system. This is prone to error if updates to time periods become out of sync.

https://github.com/ActivitySim/activitysim/blob/31705411a0632ebe02213ce3cd5fa069fade0d63/activitysim/examples/example_mtc/configs/write_trip_matrices.yaml#L258-L274

https://github.com/ActivitySim/activitysim/blob/31705411a0632ebe02213ce3cd5fa069fade0d63/activitysim/examples/example_mtc/configs/network_los.yaml#L13-L17

bstabler commented 3 years ago

I like this idea, but I also like the ability for them to be independent. I think we need the flexibility to do either with a switch/setting.

jpn-- commented 3 years ago

Instead of making these rigorously consistent by being defined together, we could just throw a warning message if they are not consistent.

jfdman commented 2 years ago

I think this issue is now a Usability improvement to throw a warning if the period definitions are not the same