search

ActivityWatch / aw-server

ActivityWatch server for storage of all your Quantified Self data.
Mozilla Public License 2.0
95 stars 55 forks source link

Opt-out for window title tracking #59

Open cunidev opened 5 years ago

cunidev commented 5 years ago

Window titles, especially in browsers, tend to leak a lot of private data (e.g. Gmail's exposing e-mails, all text editors exposing document names, etc.). </p> <p>An easy-to-configure "kill switch" flag to discard any "window title" data from watchers would solve this issue and be arguably even more suitable if enabled by default for most users.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cunidev"><img src="https://avatars.githubusercontent.com/u/13885615?v=4" />cunidev</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Just an example of how intrusive this data can't be, scrolled not to include my personal email, Twitter chat names and a purchase confirmation e-mail title including product names.</p> <p><img src="https://user-images.githubusercontent.com/13885615/66220323-1f572600-e6cd-11e9-8622-0c29193a7ce1.png" alt="image" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ErikBjare"><img src="https://avatars.githubusercontent.com/u/1405370?v=4" />ErikBjare</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>This should be done in the watcher, not the server.</p> <p>If you take a look at aw-watcher-window it should be easy to figure out how to do it. I suggest you provide a placeholder title (like "untracked") when sending the heartbeat instead of omitting it entirely (as otherwise all kinds of things that expect the field to be there will break).</p> <p>It definitely won't be enabled by default, as that is not what I expect the vast majority of users to want.</p> <p>On Fri, 4 Oct 2019, 17:35 cunidev, <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <blockquote> <p>Just an example of how intrusive this data can't be, scrolled not to include my personal email, Twitter chat names and a purchase confirmation e-mail title including product names.</p> <p>[image: image] <a href="https://user-images.githubusercontent.com/13885615/66220323-1f572600-e6cd-11e9-8622-0c29193a7ce1.png">https://user-images.githubusercontent.com/13885615/66220323-1f572600-e6cd-11e9-8622-0c29193a7ce1.png</a></p> <p>— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <a href="https://github.com/ActivityWatch/aw-server/issues/59?email_source=notifications&email_token=AAKXDOWK74ODQQBOO4SEBVDQM5PFBA5CNFSM4I5Q7J22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMBLAY#issuecomment-538449283">https://github.com/ActivityWatch/aw-server/issues/59?email_source=notifications&email_token=AAKXDOWK74ODQQBOO4SEBVDQM5PFBA5CNFSM4I5Q7J22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMBLAY#issuecomment-538449283</a>, or mute the thread <a href="https://github.com/notifications/unsubscribe-auth/AAKXDOTZ2WXO2TGPOUU2HCDQM5PFBANCNFSM4I5Q7J2Q">https://github.com/notifications/unsubscribe-auth/AAKXDOTZ2WXO2TGPOUU2HCDQM5PFBANCNFSM4I5Q7J2Q</a> .</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cunidev"><img src="https://avatars.githubusercontent.com/u/13885615?v=4" />cunidev</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>I just discovered that aw-watcher-window already supports this feature, though not documented and only as a run-time argument instead of something in the configuration file. Should an "incognito" parameter (possibly with some levels) be added at config level for watchers to know what kind of data to ignore?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/johan-bjareholt"><img src="https://avatars.githubusercontent.com/u/1398500?v=4" />johan-bjareholt</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>I just discovered that aw-watcher-window already supports this feature, though not documented and only as a run-time argument instead of something in the configuration file.</p> </blockquote> <p>Oh right, I had forgotten about that completely.</p> <blockquote> <p>Should an "incognito" parameter (possibly with some levels) be added at config level for watchers to know what kind of data to ignore?</p> </blockquote> <p>Filter specific titles seems a bit excessive and would probably be a bit overkill, but if you have a use-case for a exclude-title property in the config feel free to add that.</p> <p>Still though, the best solution for your use-case sounds like it should be to just to start aw-watcher-window with the --exclude-title flag.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cunidev"><img src="https://avatars.githubusercontent.com/u/13885615?v=4" />cunidev</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Actually my main concern was a lack of a GUI frontend for this. As I'm working on a Gtk GUI for AW, I wanted to make sure this aspect was easily configurable by the user (why not, if all other options are expressed in a dedicated configuration file?). So ok, I'll work on that soon. Could we move this issue to <code>aw-watcher-window</code>?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cunidev"><img src="https://avatars.githubusercontent.com/u/13885615?v=4" />cunidev</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>I've made a PR here, feel free to review it: <a href="https://github.com/ActivityWatch/aw-watcher-window/pull/37">https://github.com/ActivityWatch/aw-watcher-window/pull/37</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>