search

ActivityWatch / aw-watcher-window

Cross-platform window watcher (for use with ActivityWatch)
Mozilla Public License 2.0
91 stars 53 forks source link

Make watcher shutdown as aw-qt parent process dies. #20

Closed nikanar closed 7 years ago

nikanar commented 7 years ago

https://github.com/ActivityWatch/aw-qt/issues/19

This makes the child process (the watcher) check it's PPID, so that if ever its parent process dies (aw-qt), this one shutdowns also. 1 is PPID of init process, what PPIDs get set to when parents die (aka "the orphanage").

Sorry for the commit fluff, git still gets the better of me.

johan-bjareholt commented 7 years ago

Great work! 👍

Are committing with another user than on GitHub or did someone else do the commits? Personally I don't care since it looks great anyway, but next time if you want to top the contributors list I would recommend setting your email in your git config to the same as your github account so the commits are linked to you.

Sorry for the commit fluff, git still gets the better of me.

No problem, it's a small PR so i can just squash and merge so they look like one complete commit later :)

ErikBjare commented 7 years ago

Just a note: This has the same issue with PyInstaller as I mentioned in https://github.com/ActivityWatch/aw-watcher-afk/pull/24

nikanar commented 7 years ago

It's me, holding on wrong config files (fixed now). Thanks :)