search

ActivityWatch / aw-watcher-window

Cross-platform window watcher (for use with ActivityWatch)
Mozilla Public License 2.0
91 stars 53 forks source link

build(deps): added pyinstaller to optional dependencies #53

Closed iloveitaly closed 3 years ago

iloveitaly commented 3 years ago

This was required in order to run make package.

Also bumped pyobjc versions. This eliminates this error I ran into RuntimeError: Wrong version of PyObjC C API (got 21, expected 20).

johan-bjareholt commented 3 years ago

PyInstaller is only an optional dependency so it should not be in the dependencies.

Could you change the PR to only bump up the pyobjc dependencies?

iloveitaly commented 3 years ago

Is it optional because someone could build & run from the cli without packing it up within an application?

Could you change the PR to only bump up the pyobjc dependencies?

What do you think about optional = true instead of removing it, since it's required to run make package?

ErikBjare commented 3 years ago

Is it optional because someone could build & run from the cli without packing it up within an application?

It's optional because when we bundle everything in the main activitywatch repo it gets to decide which pyinstaller version to use (as it should use the same version for all modules).

What do you think about optional = true instead of removing it, since it's required to run make package?

That'd be alright! As long as it isn't installed by default (which would interfere with pre-installed versions of pyinstaller, as in the main/bundle repo's CI).

iloveitaly commented 3 years ago

It's optional because when we bundle everything in the main activitywatch repo it gets to decide which pyinstaller version to use (as it should use the same version for all modules).

Ah, that makes complete sense! I didn't catch that. Thanks for explaining.