Closed ideadapt closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 25.98%. Comparing base (
0cf7831
) to head (c41e6e1
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great changes!
My main concern i s how does this look on small screens now? Some of the things in the design that you rightfully questioned (the flex and right-float) were actually done they were for small screens, so they look good in the aw-android app.
I wasn't aware of the mobile app requirement. I optimized it for screens >=640px. My tests today showed that it would work down to 540px:
Testing the old UI on mobile showed that, at least for my computer host names, the timeline is not useful on mobile screens. The bucket events start to get visible with >450px:
Are there requirements to support screens smaller than 540px? If so, I could try to shrink the duration selection on small screens.
@ideadapt Yes, the same UI is used for aw-android which runs on phones. The bucket id is a lot shorter on Android, mine is aw-android-test
and it takes up ~30% of the width on my phone. Not great, but useable.
We used to support landscape mode, so one could make it work pretty well if one wanted, but there was an issue with full reloads on orientation changes, so we disabled it "temporarily" and thats where its still at: https://github.com/ActivityWatch/aw-android/pull/108
So yeah, still need to support/think about small screens, but I'm okay with things not being perfect (since they're not anyway with the tight timeline).
Again, very nice work! I think I'll take it from here :)
Will be really great to have both this and https://github.com/ActivityWatch/aw-webui/pull/609 in the next release!
Merged! Thank you again for this great work!
Merged! Thank you again for this great work!
Cool! Thank you :)
I use the Timeline view at least once a day. The number of clicks required to filter the time range started to bug me, so I tried to improve it:
Fixes https://github.com/ActivityWatch/aw-webui/issues/395
Before:
After:
Summary:
Improves Timeline view usability by reducing clicks for time filters, replacing dropdowns with buttons, and adding user notifications for no events.
Key points:
src/components/InputTimeInterval.vue
: Removed "mode" select, displaying both filters directly.last_duration
on button click.src/views/Timeline.vue
: Adjusted event count display and added alert for no events.Generated with :heart: by ellipsis.dev