search

Ad5001 / BetterGen

PocketMine's Tomorrow's World Generator. Mirror of
https://git.ad5001.eu/Ad5001/BetterGen
Other
58 stars 27 forks source link

Update ? #39

Closed BabaToutCourt closed 6 years ago

BabaToutCourt commented 6 years ago

Can you update the plugin in 3.0.0-ALPHA10 ? Thanks

AvgZing commented 6 years ago

Feel free to modify the plugin.yml yourself. For now, there are some features that are broken such as lakes (in the latest alpha), so be sure to use json options for that.

chrispoupart commented 6 years ago

Unfortunately, the code as is in master doesn't work just by bumping the API in plugin.yml. When doing so, I get this:

pocketmine     | [12:51:52] [Server thread/CRITICAL]: ErrorException: "file_put_contents(/pocketmine/BetterGen/processingLoots.json): failed to open stream: No such file or directory" (EXCEPTION) in "/config/plugins/BetterGen/src/Ad5001/BetterGen/Main" at line 71
pocketmine     | [12:51:52] [Server thread/DEBUG]: #0 (): pocketmine\error_handler(integer 2, string file_put_contents(/pocketmine/BetterGen/processingLoots.json): failed to open stream: No such file or directory, string /config/plugins/BetterGen/src/Ad5001/BetterGen/Main.php, integer 71, array Array())
pocketmine     | [12:51:52] [Server thread/DEBUG]: #1 /config/plugins/BetterGen/src/Ad5001/BetterGen/Main(71): file_put_contents(string /pocketmine/BetterGen/processingLoots.json, string {})
pocketmine     | [12:51:52] [Server thread/DEBUG]: #2 src/pocketmine/plugin/PluginBase(90): Ad5001\BetterGen\Main->onEnable()
pocketmine     | [12:51:52] [Server thread/DEBUG]: #3 /config/plugins/PocketMine-DevTools.phar/src/FolderPluginLoader/FolderPluginLoader(127): pocketmine\plugin\PluginBase->setEnabled(boolean 1)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #4 src/pocketmine/plugin/PluginManager(610): FolderPluginLoader\FolderPluginLoader->enablePlugin(Ad5001\BetterGen\Main object)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #5 src/pocketmine/Server(1955): pocketmine\plugin\PluginManager->enablePlugin(Ad5001\BetterGen\Main object)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #6 src/pocketmine/Server(1941): pocketmine\Server->enablePlugin(Ad5001\BetterGen\Main object)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #7 /config/plugins/PocketMine-DevTools.phar/src/DevTools/DevTools(49): pocketmine\Server->enablePlugins(integer 0)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #8 src/pocketmine/plugin/PluginBase(90): DevTools\DevTools->onEnable()
pocketmine     | [12:51:52] [Server thread/DEBUG]: #9 src/pocketmine/plugin/PharPluginLoader(122): pocketmine\plugin\PluginBase->setEnabled(boolean 1)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #10 src/pocketmine/plugin/PluginManager(610): pocketmine\plugin\PharPluginLoader->enablePlugin(DevTools\DevTools object)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #11 src/pocketmine/Server(1955): pocketmine\plugin\PluginManager->enablePlugin(DevTools\DevTools object)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #12 src/pocketmine/Server(1941): pocketmine\Server->enablePlugin(DevTools\DevTools object)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #13 src/pocketmine/Server(1655): pocketmine\Server->enablePlugins(integer 0)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #14 src/pocketmine/PocketMine(554): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /pocketmine/, string /pocketmine/plugins/)
pocketmine     | [12:51:52] [Server thread/DEBUG]: #15 /pocketmine/PocketMine-MP.phar(1): require(string phar:///pocketmine/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
pocketmine     | [12:51:52] [Server thread/INFO]: Disabling BetterGen v1.0999999999999

I was however able to do get it to at least load using e7ef5620d12cb4414c45a3c7bd81738f18db084c and changing the plugin.yml file.

This plugin looks fantastic. I am not much of a PHP programmer, else I would love to help. My kids would definitely love a more exciting map to explore! I hope that a new release is forthcoming.

Keep up the nice work!

AvgZing commented 6 years ago

I'll certainly see what I can do.

AvgZing commented 6 years ago

@Ad5001 You fixed it? This should be closed, then

chrispoupart commented 6 years ago

plugin.yml is still set for ALPHA9 API, but switching that to 10 does allow this plugin to load now.

Ad5001 commented 6 years ago

Well, it compatible now so I'll update it to alpha 10 when I'll have fixed some bugs.