search

AdAstra-LD / DS-Pokemon-Rom-Editor

New DS Pokemon ROM Editor, based on Nømura's 2020 edition. Expanded with loads of new features, bugfixes and better usability.
153 stars 43 forks source link

Incorrect DVs for trainers in HGSS #20

Closed OtakuGracie closed 1 year ago

OtakuGracie commented 1 year ago

The DV displayed for a number of trainers' pokemon in HGSS is incorrect. Examples include all elite four members, leader claire, and a number of others. For those it displays incorrectly they seem to be off by 8192. My guess is that the value read in for a trainer's pokemon's DV also holds a different value that is simply set to 0 for many pokemon in the trainer files. This issue seems to be specific to HGSS from my testing.

DSPRE_HGSS_DV_Error

AdAstra-LD commented 1 year ago

As much as I agree with your intuition, without knowing the effect that 8192 has on the DV number, it's hard for me to imagine a more correct way to display that value. It may be a bit flag on bit #13, it may be part of a wider bitfield... At the moment, I don't know.