search

AdRoll / goamz

Fork of the GOAMZ version developed within Canonical with additional functionality with DynamoDB
https://wiki.ubuntu.com/goamz
Other
401 stars 214 forks source link

removed duplicate code same can be achived by other common functions #432

Closed pwnsrma closed 8 years ago

pwnsrma commented 8 years ago

Removed NewEqualInt64AttributeComparison() and NewEqualStringAttributeComparison().

Same can be achieved by NewNumericAttributeComparison() and NewStringAttributeComparison()

alimoeeny commented 8 years ago

Thanks @pwnsrma , I understand that we shouldn't have these duplicated in the first place, but at this moment, it is possible that people are using them, right? so we will just break their code next time they pull. Since this is not an active library I am hesitant to merge this in. Or am I misunderstanding something?

pwnsrma commented 8 years ago

@alimoeeny totally agreed , so lets not merge this.