search

AdamBrodzinski / meteor-phonegap-oauth

Fixes how Meteor handles OAuth popups on PhoneGap/fullscreen
MIT License
33 stars 7 forks source link

Facebook Tweak #6

Open HynesIP opened 10 years ago

HynesIP commented 10 years ago

Anyone had any luck tweaking this plugin for FB? Works great for Twitter.

AdamBrodzinski commented 10 years ago

@HynesIP , hoping to add Facebook, Github, and Google this weekend (Google has partial support currently).

HynesIP commented 10 years ago

Excellent, Adam. Thank you, for the plugin.

AdamBrodzinski commented 10 years ago

I have a partial working branch for facebook here: https://github.com/AdamBrodzinski/meteor-phonegap-oauth/tree/facebook

There's an issue with the nth login not working. The only way to get it to log in again is to uninstall the app and reinstall. Not sure if this is a FB issue or a PhoneGap issue... SO had several references to facebook showing a white screen when trying to login so I suppose it could be related.

The easiest way to try it out would prob be editing the smart.lock file and adding the facebook branch.

AdamBrodzinski commented 10 years ago

@HynesIP let me know how it works out. I'll try and work on it again next weekend.

HynesIP commented 10 years ago

Sounds FBish. I'll study the logs and see if I can pinpoint a ill using that branch, and report back. Thank you again!

HynesIP commented 10 years ago

I didn't pinpoint the cause of the nth login not working, but can say it doesn't occur in Android, which works as expected. I recall a similar issue when adding the FB PhoneGap plugin last year. As you said, a reinstall was a reliable solution. I don't recall if I found a cause or solution in that case. I'll keep looking at it. BTW, I forked the current version and wrapped the android check with a check for device. TY

andrewreedy commented 10 years ago

https://github.com/andrewreedy/meteor-accounts-facebook-cordova Made a package to work with facbeook single sign on / native sdk. Works now.. going to work on making using the graph api easier too :)

nunohvidal commented 10 years ago

I managed to get FaceBook to work as well, besides Google and Twitter.

What I've done was to move the "close();" call in file "patch_window.js" from line 89 to the if block right after "Accounts.oauth.tryLoginAfterPopupClosed(credentialToken);"

Can someone else report success as well with this change?

Thanks @AdamBrodzinski for this great package!