Addepar / ember-table

https://opensource.addepar.com/ember-table/
Other
1.69k stars 351 forks source link

Ember 2.0 support? #400

Closed supersabillon closed 7 years ago

supersabillon commented 8 years ago

I'm using the ember-2.0 branch in my project, but trying to run the Hello World table example gives me this error in the console:

Uncaught Error: Assertion Failed: A helper named 'fixed-grid-layout' could not be found

is this a known issue or am I doing something wrong? thanks

MartinMalinda commented 8 years ago

The ember collection which is listed as dev dependency should probably be a dependency. Ember install ember-collection should solve this issue.

cyril-sf commented 8 years ago

@supersabillion, @MartinMalinda is correct, I need to fix that.

cwiese commented 8 years ago

Has anyone stress tested this branch? Once again we need a GRID in Ember land and there are not a lot of good options (like React land) .....I want to try Ember Table again

DanChadwick commented 8 years ago

It has pretty good performance with 1000-ish rows. Not sure about a huge number of rows. One limitation is that there are observers in the cells. These can be eliminated with a computed property if you can swallow some simplifications: a) constant contentPath for each column and b) cellContent is just a property (calling the model's getCellContent). There are probably lots of other opportunities for optimization too. The above only affects the visible cells, not the total number of cells.

Rows are created for each model. There is overhead there, obviously.

cwiese commented 8 years ago

Would this be the best choice for a Grid in the Ember-world today …with sortable, filterable, hide-able columns, that scrolls like Slick Grid :-)

On Apr 12, 2016, at 2:32 PM, Dan Chadwick notifications@github.com wrote:

It has pretty good performance with 1000-ish rows. Not sure about a huge number of rows. One limitation is that there are observers in the cells. These can be eliminated with a computed property if you can swallow some simplifications: a) constant contentPath for each column and b) cellContent is just a property (calling the model's getCellContent). There are probably lots of other opportunities for optimization too. The above only affects the visible cells, not the total number of cells.

Rows are created for each model. There is overhead there, obviously.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/Addepar/ember-table/issues/400#issuecomment-209044282

DanChadwick commented 8 years ago

It has provision for doing sorting and filtering in that you can implement it yourself. It does not do it out-of-the-box. It does lazy rendering -- only what is in the viewport is in the DOM, so the total list size matters much less. There are still O(N) and probably at least O(N log N) performance because the whole list of rows is processed. Your performance mileage may vary.

cfator commented 8 years ago

When running against Ember/Ember-CLI: 2.4.5/2.4.3 with ember-collection: v1.0.0-alpha.5, I get this error when starting up Ember Server: Error:

Assertion Failed: Using {{view}} or any path based on it ('arms-ui/templates/body-table-container.hbs' @ L5:C8) has been removed in Ember 2.0

Which is leading me to believe that ember-table is not ready for recent versions of Ember?

MartinMalinda commented 8 years ago

@cwiese I think when Glimmer 2 lands, current perf issues will be gone

Datamance commented 8 years ago

@MartinMalinda or @cyril-sf - do you have an idea of when the 2.0-appropriate changes are going to be merged into the primary branch? Is there a new major release in the pipeline that will include Ember 2.0 support, or is this something that will be bundled with a more minor update?

pzuraq commented 7 years ago

Hey all, I'm closing this issue in favor of #418.

We are planning on releasing a new version soon, we've been hard at work on a next generation occlusion library, vertical-collection, to replace Ember.ListView. Now that it's nearly complete we're planning on working on the next generation.

We'd love your feedback, feel free to add any thoughts to the main discussion issue or ping us in #e-table on the Ember Community Slack!