search

AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.14k stars 335 forks source link

Once in a while Adguard addon acts as if I just installed it opening welcome page + clearing whitelist #936

Closed AjvarXX closed 6 years ago

AjvarXX commented 6 years ago

This one might be a result of improper browser shutdowns due to BSODs so figure if report is valuable or not. But it happened after updating to the latest WHQL. Profile is basically fresh (over a week as I created it, synced tabs and history, installed addons).

Steps to reproduce

  1. Launch browser once in a while (happens once per day or per 2 days)
  2. Perhaps a BSOD when browser was opened (happened few times)

Expected behavior

nothing

Actual behavior

New welcome tab opens with option to set settings https://welcome.adguard.com/v2/thankyou.html?v=2.8.5&cid=Sf05ibBb37485573&lang=uk&id=adguardadblocker%40adguard.com&_locale=uk Also whitelist is wiped

Screenshot:
Screenshot of the browser console: ![ctrlshiftj](https://user-images.githubusercontent.com/9568793/35231218-e041f946-ffa0-11e7-8d5c-3d781669da76.JPG)

Your environment

ameshkov commented 6 years ago

WHQL?

ameshkov commented 6 years ago

clearing whitelist

Are you sure it's just the whitelist and not the whole storage?

AjvarXX commented 6 years ago

To be precise it erases everything but user filter rules and maybe chosen filters but most likely only user rules stay intact. It erased welcome settings (those 5 sliders), whitelist and latest 4 sliders (I disable context menu while now it reenabled itself). As for other settings I don't see changes because was by default.

WHQL updated over beta days ago, yes, I think I didn't notice this problem when was on Beta 2.8.5 (not that I stayed for long anyway considering WHQL arrived few days later).

I will try uninstalling it and installing WHQL.

ameshkov commented 6 years ago

There should be some kind of a race condition causing that.

Got a couple more complains from ppl on other browsers.

ameshkov commented 6 years ago

@Mizzick @atropnikov

Everything on the background page gets initialized before the storage is finished initializing.

Seems like a clear race condition to me.

atropnikov commented 6 years ago

@AjvarXX Could you please, when it will occur again, do the following: disable and enable AdGuard addon and see what happens. Will be settings loaded or stay default? Also please attach a content of the storage file. You can find it in your Firefox (Waterfox) Profiles folder. Something like this: PATH TO BROWSER PROFILES FOLDER/Profiles/PROFILE NAME/browser-extension-data/adguardadblockerbeta\@adguard.com/storage.js Thank you!

AjvarXX commented 6 years ago

Yes, looking at storage folder at least in my case it were BSODs that had influence on that. I see few .corrupt files. Strangly I didn't have problems with earlier addon versions, did it have a restore backed up storage.js feature? I will install *.3 Beta addon to test. adguardadblocker@adguard.com.zip

ameshkov commented 6 years ago

did it have a restore backed up storage.js feature

Not really, there are no major changes between .3 and .4

Mizzick commented 6 years ago

Do we still have these problems?

AjvarXX commented 6 years ago

@Mizzick as long, as I went to stable PC (no BSODs) I had no more such problems. I still suspect that previous version was more bsod-resistant but doubtfully workload on unstable hardware should be a matter of concern for developers.

Mizzick commented 6 years ago

@AjvarXX thanks for your feedback anyway. There were some problems on stable hardware aswell, but we didn't receive more complaints about, so I think the issue could be closed now.