AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.44k stars 202 forks source link

About pre-installed subscription list #1298

Open bigdargon opened 5 years ago

bigdargon commented 5 years ago

Prerequisites

Problem Description

There are currently 3 pre-installed lists, of which Adaway and hpHosts are the host format. I use Adguard Pro for a long time, I see:

The list mentions very few users.

Proposed Solution

Team Adguard can add rule format subscriptions such as the AdGuard SDN filter. I propose the list I maintain and is being used in Vietnam as hostsVN.

Github: https://github.com/bigdargon/hostsVN

URL: https://raw.githubusercontent.com/bigdargon/hostsVN/master/filters/adservers-all.txt

Wiki: https://github.com/bigdargon/hostsVN/wiki/Adguard-Pro

Alternatives Considered

Delete the Adaway and hpHosts lists

Additional Information

I really like Adguard on iOS with the wildcard support filter. For example, if I list the ||abc.com^ rule, it will block bothabc.com and www.abc.com; or the||abc-*.com^ rule will block domain names of abc-123.com and abc-xyz.com. While the hosts format has many of the same rules. For example in the hosts format, blocking the domain name doubleclick.net will block subdomains with multiple rules. So using separate lists that fully support Adguard will make the filter simpler and smaller than the hosts format.

ameshkov commented 5 years ago

@bigdargon thank you!

For now, I've assigned this feature request to v3.4 milestone. By that time we should already restore the system-wide blocking functionality in the main app and implement the custom blocklists functionality. After that, we can start thinking about which blocklists should be included.

lancelot-moon commented 5 years ago

Before that, realizing this is more important. https://github.com/AdguardTeam/AdguardForiOS/issues/1215

For Japanese domains: 280blocker adblock domain lists: https://280blocker.net/files/280blocker_domain_ag.txt

For Chinese domains: Yhosts: https://raw.githubusercontent.com/vokins/yhosts/master/hosts.txt

ad-wars: https://raw.githubusercontent.com/jdlingyu/ad-wars/master/hosts

Misc: 1Hosts (mini): https://1hos.cf/mini/hosts.txt

CoinBlockerLists: https://gitlab.com/ZeroDot1/CoinBlockerLists/raw/master/hosts

Ransomware Tracker Domain Blocklist: Maybe iOS doesn't need this. https://ransomwaretracker.abuse.ch/downloads/RW_DOMBL.txt

Energized Spark Protection: https://raw.githubusercontent.com/EnergizedProtection/block/master/spark/formats/filter

bigdargon commented 5 years ago

@lancelot-moon In my opinion, preset lists should categorize hosts and rules format. As I said above, hpHosts blocks the domain doubleclick.net but has more than 1,000 lines with subdomains, which is a waste of application and device resources. While the rule format that Adguard supports, it only takes one line of rule ||doubleclick.net^ to block all subdomains.

Too many lists will make it difficult for users to choose and the team should choose the lists with regular frequency updates to add new or remove the wrong blocking domain.

lancelot-moon commented 5 years ago

Simply, AG SDN filter lacks rules for localized ad domains.

Your list may be for Vietnam, not for most users.

Just let users choose some from them.

Notifying users about the upper limit of rules for DNS filtering in app is more important.

bigdargon commented 5 years ago

I also think there should be warnings for users to choose. And I want to add my listing so that users in Vietnam don't need to find and copy that address.

Although the advertising domain in Vietnam has been merged with AG SDN, I still want a complete list of rules to get the best support!

This rule merged https://raw.githubusercontent.com/bigdargon/hostsVN/master/filters/adservers.txt

ameshkov commented 4 years ago

It seems that Apple won't give us a choice here. We cannot include ad blocking blocklists by default so in any case, the users will have to find them on their own.

On a side note, we should add it to AdGuard Home: https://github.com/AdguardTeam/AdGuardHome/issues/1325

lancelot-moon commented 4 years ago

Please also add it to AdGuard for Android.