AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.43k stars 202 forks source link

errors when tunnel starts with encrypted DNS #744

Closed zebrum closed 6 years ago

zebrum commented 6 years ago

740 #742 #743

User ID: 1425202

lancelot-moon commented 6 years ago

Split-Tunnel mode starts with encrypted DNS: https://github.com/AdguardTeam/AdguardForiOS/issues/740

From Split-Tunnel mode (ever enabled) to Full-Tunnel mode and then start with encrypted DNS: https://github.com/AdguardTeam/AdguardForiOS/issues/742 https://github.com/AdguardTeam/AdguardForiOS/issues/743

There is no such issue with general DNS. These issues should only occur with encrypted DNS.

lancelot-moon commented 6 years ago

These issues aren’t solve in beta v2.1.0(149). If it is necessary to give enough setup time for encrypted DNS, you should consider about it... Thanks a lot!

IvanIin commented 6 years ago

@lancelot-moon can you send logs?

lancelot-moon commented 6 years ago

I just sent the bug report to AdGuard Support at 18:46 on 12th April (GMT+8). User ID: 1425202 Subject: [AdGuard Pro for iOS] bug report

I only sent the bug report about invalid adblock with split-tunnel mode and encrypted DNS.

Reproduction steps: **1. Enable AdGuard Pro protection with split-tunnel mode and general DNS from the beginning.

  1. Turn off AdGuard Pro protection.
  2. Only change to use encrypted DNS (ex: DNSCrypt AdGuard DNS) from general DNS. It will automatically enable AdGuard Pro protection.
  3. Open other apps with ads. Ad blocking is invalid.**

From Split-Tunnel mode (ever enabled) to Full-Tunnel mode and then start with encrypted DNS. https://github.com/AdguardTeam/AdguardForiOS/issues/743 It's also not solved. Do I need to send another bug report about it again although there is no difference, compared with before?

lancelot-moon commented 6 years ago

@ameshkov @IvanIin

Thanks, Ivanlin. You prove that they're bugs, not jokes. AG Pro beta v2.1.0(151) does great work for VPN connection.

Only https://github.com/AdguardTeam/AdguardForiOS/issues/742#issuecomment-379232926 isn't solved. I had enabled AG Pro VPN in app, but VPN status in iOS setting was still off. (Try more times. You can get it.) Is it due to unstable Full-Tunnel mode (no VPN icon)? In such situation, when I run some apps which do internet connection, VPN status would be automatically from "off" to "on".

It seems that https://github.com/AdguardTeam/AdguardForiOS/issues/740, https://github.com/AdguardTeam/AdguardForiOS/issues/743 and https://github.com/AdguardTeam/AdguardForiOS/issues/752 are solved in AG Pro beta v2.1.0(151).

The issues of AG Pro VPN connection really torment AdGuard's iOS users. I think that you can release hotfix update on App Store if you don't plan to do more other enhancement in v2.1.0.

Another thing: Do you want to modify the title and description of AG (Pro) for iOS on App Store? I saw the changes on oneskyapp. But I don't know if I should start to translate them because I worry that it's not final conclusion. Just check with you.

Future plans about my other main suggests on GitHub: a. DNScrypt v2 Maybe you also need to update encrypted DNS list in AG Pro for iOS. https://github.com/AdguardTeam/AdguardForAndroid/issues/1831 b. DoH/DoT support (encrypted Google DNS and Cloudflare DNS) c. Add separate switches to turn on / off blacklist, whitelist & each subscription and Safari Content Blocking's filters, user filter & whitelist. d. Checkbox for enabling/disabling rules in Safari Content Blocking's user filter & whitelist and Privacy settings' user rules (blacklist & whitelist). e. Show the sum of current active rules [user rules (blacklist & whitelist )+ subscriptions] on the top of Privacy Settings, which is convenient for users. f. Let a tap for enabling or disabling DNS requests log back. (Pause the logging.) g. Ability to edit subscription profile. h. Please give max size of 20 custom DNS servers in DNS setting from AG Pro v2.0.0. & Improve the layout in DNS setting. i. Please add Cloudflare Public DNS and others in the known DNS list. j. Please change the arrangement of tutorial videos from vertical stack to overlapping on the main screen. It's about aesthetics of app's interface on the main screen. The scene of tutorial video is fashionable and modern to the sense of sight. Such like a beautiful banner there. However, it'll give different feeling on main screen with different arrangement. Vertical stack of the videos: inharmonious Overlapping the videos: harmonious Hiding all videos: ugly k. Select to periodically or manually backup the profiles of custom DNS servers, the blacklist / whitelist in the user rules of Privacy Settings, subscriptions (filters) in Privacy Settings and the user filter & whitelist in SAFARI Content Blocking to iCloud. Synchronize these profiles between all users' devices by using iCloud. https://github.com/AdguardTeam/AdguardForiOS/issues/535#issuecomment-357449050

B/R

lancelot-moon commented 6 years ago

Hi, I have tried AG Pro beta v2.1.0(152).

It seems that https://github.com/AdguardTeam/AdguardForiOS/issues/742#issuecomment-379232926 is also solved.

From AG Pro v1.0~v2.0, unstable VPN tunnel is the most obvious shortcoming for AdGuard Pro for iOS. However, AG Pro beta v2.1.0(151/152) deeply surprises me. You really did hard work in VPN tunnel this time! Thank you very much!

lancelot-moon commented 6 years ago

@ameshkov @IvanIin

Hi,

What did you change in AG Pro beta v2.1.0(153)? Originally, ad blocking worked.

After I operated between different VPN tunnel mode and general/encrypted DNS, ad blocking became invalid. (But those ad domains were shown "blocked" in DNS Requests Log.) Even I tried to reboot iphone, downgrade to v2.1.0(152) or delete AdGuard Pro and then reinstall it, which is useless.

It seems that something is latched. Need a method to unlatch. Finally, I found the key to unlatch the situation of invalid adblocking. I turned on real VPN and then turn off. (I used Disconnect Premium app.) I went to enable AdGuard Pro, and then adblocking was back.

I already sent the bug report to AdGuard Support at 09:36 on 27th April (GMT+8). User ID: 1425202 Subject: [AdGuard Pro for iOS] bug report

ameshkov commented 6 years ago

@lancelot-moon is there any way to reproduce this issue again?