AdhocAdam / smletsexchangeconnector

SMLets PowerShell based Exchange Connector for controlling Microsoft System Center Service Manager 2016+
https://adhocadam.github.io/smletsexchangeconnector/
GNU General Public License v3.0
29 stars 19 forks source link

Event log exposes password when not using Run As Accounts #480

Open BetaLyte opened 5 months ago

BetaLyte commented 5 months ago

I noticed the event error log is currently leaking the password of the SCSM Run As Account, as it's being printed out if the email validation fails:

https://github.com/AdhocAdam/smletsexchangeconnector/blob/02be0b1aed028647848c982e19ae5779c7596822/smletsExchangeConnector.ps1#L4938

AdhocAdam commented 5 months ago

Looks like this occurs given the following:

In any case, much appreciated and thank you for the pull request 👍

AdhocAdam commented 5 months ago

I was a bit too quick to close this. I merged this into dev and will keep this issue open for the sake of transparency.