AdobeXD / xd-to-flutter-plugin

Generate assets from XD for use in an existing Flutter project
BSD 2-Clause "Simplified" License
953 stars 97 forks source link

Repeat Grids with homogenous component instances export incorrectly #88

Closed gskinner closed 3 years ago

gskinner commented 3 years ago

Bug Description

If all of the component instances in a repeat grid have the same values for a named parameter, that parameter is omitted from the generated data list. This leads to a Flutter RTE because it still injects the (missing) variable into the template.

To Reproduce

Create a repeat grid with multiple items from a component "Foo", that has a named parameter "label". Do not change the value of label for any of the instances. Export and run the generated view. You will see an error similar to:

Error: The getter 'label' isn't defined for the class 'Foo'.

gskinner commented 3 years ago

Pushed a fix for this, but I'd like to do some additional testing.

gskinner commented 3 years ago

Appears to be fully fixed in v1.1.0