search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
97 stars 15 forks source link

[FORGE] improve mod compatiblity by cancelling forge events #59

Closed AlexModGuy closed 4 months ago

AlexModGuy commented 9 months ago

Version Information

Minecraft Version: 1.20+

Describe the Bug

Nostalgic Tweaks directly sets fog near and far plane distance via RenderSystem calls, rather than let Forge's event system handle this by properly cancelling the fog event, and setting the event's near and far plane distance. This leads to issues with other mods that expect these values to pertain to the actual fog, such as https://github.com/AlexModGuy/AlexsCaves/issues/781.

Bug Context

https://github.com/Adrenix/Nostalgic-Tweaks/blob/1.20/common/src/main/java/mod/adrenix/nostalgic/util/client/FogUtil.java#L170 Direct calls to RenderSystem bypass the forge event's setFarPlaneDistance() and setNearPlaneDistance(), meaning that any other mod which expects these values to return the start and end of the fog will recieve old, incorrect results. I propose you change the return type of the FogUtil methods to return the three wanted values, and use event's setters rather than set them directly.

Adrenix commented 4 months ago

Thank you for pointing this out! I implemented the events in beta 9. This will eventually receive a backport fix for 1.20.1.