search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
97 stars 15 forks source link

[FABRIC] Makes Bumblezone super dark by not respecting the ambient lighting values in the dimension type #68

Closed TelepathicGrunt closed 3 months ago

TelepathicGrunt commented 6 months ago

Version Information

Minecraft Version: 1.20.1 Fabric Loader Version: 0.92.2 Fabric API Version: 0.15.11 Nostalgic Tweaks Version: 2.0.0-Beta-8.4.1

Describe the Bug

Nostalgic Tweaks does not respect the ambient lighting value that modded dimensions may have. For Bumblezone, it is this value here:

https://github.com/TelepathicGrunt/Bumblezone/blob/1a354fdb15d2c517e174a56a6274a9fb661f5617/common/src/main/resources/data/the_bumblezone/dimension_type/the_bumblezone.json#L5

You can quickly enter my dimension by doing /execute in the_bumblezone:the_bumblezone run tp ~ 90 ~

Screenshots

What the bugged look of my dimension is with Nostalgic Tweaks: image

What it is supposed to look like (Nostalgic Tweaks removed): image

image

TelepathicGrunt commented 6 months ago

Turning on this value fixes the issue image

However, I still consider it a bug that Nostalgic Tweaks does not respect the Dimension Type ambient lighting value for datapack/modded dimensions.

Adrenix commented 5 months ago

This was definitely an oversight on my part. The Old Classic Light Rendering forces the lightmap to be full-bright, which is why turning that on made everything look like it should. I added ambient lighting into the old lighting brightness calculation. The result is not as bright as the "expected" screenshot, but the old lighting was famously very dark. image The old lighting can be made brighter by setting Disable Vanilla Brightness to disabled, which will let the brightness setting in the video settings impact the light texture map again. image Thank you for the report and screenshots, this is a very cool dimension/mod!

Adrenix commented 3 months ago

This issue is resolved in beta 9 for 1.20.1. Thank you for submitting this!