search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
97 stars 15 forks source link

[FABRIC] Sodium 0.6 crash on world join with "Old Water Lighting" enabled #74

Closed helpimnotdrowning closed 3 months ago

helpimnotdrowning commented 4 months ago

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20.1 Fabric Loader Version: 0.15.11 Fabric API Version: 0.92.2+1.20.1 Nostalgic Tweaks Version: 2.0.0-Beta-8.4.1 Sodium Version: 0.6.0-alpha.2 (via Iris Discord server, message link )

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

Minecraft crashes when joining a world with Iris' Sodium 0.6 alpha 2 build when "Old Water Rendering" is enabled

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

https://gist.github.com/helpimnotdrowning/4dd1b605f937480a3bb7dfccd6fa0ae4

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

n/a

Notes

image

As mentioned by IMS in the Iris 1.8 alpha 3 support thread, the Sodium method net.caffeinemc.mods.sodium.client.world.LevelSlice.method_22336 (getLightEngine) is called here, in Nostalgic Tweaks, instead of the vanilla net.minecraft.world.level.BlockAndTintGetter.getLightEngine (for some reason?), which will only throw UnsupportedOperationException, which kills the game.

Adrenix commented 3 months ago

Beta 9 is now version locked to Sodium 0.5.x. An update will be needed to support Sodium 0.6.x.

helpimnotdrowning commented 3 months ago

Great, that's fine!