search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
97 stars 15 forks source link

Add tweak for the old creative menu #94

Open Xenthio opened 2 months ago

Xenthio commented 2 months ago

This PR is a doozy and contains some less than satisfactory code for the sake of customisation.

forkiesassds commented 2 months ago

I appreciate the effort, however I have a few problems with this pull request. First of all the code largely looks like it’s copied from an old version of Minecraft. Furthermore the blocks list is hardcoded with an unnecessary and very verbose option, it should be up to data packs to control the order and blocks listed. Additionally the 0.30 creative menu is very limited and not at all suitable for use apart from some niche cases.

Xenthio commented 2 months ago

Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really.

forkiesassds commented 2 months ago

Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really.

Variable names within the code suggest otherwise. Besides it should not be up to the mod itself to determine the item layout within the inventory

Xenthio commented 2 months ago

Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really.

Variable names within the code suggest otherwise. Besides it should not be up to the mod itself to determine the item layout within the inventory

Ahh yeah okay i see them, I guess I forgot about those haha, those are mostly so creative inventory behaviours match with modern minecraft.