search

AdrianWilczynski / OneDarkPro

"One Dark Pro" theme for Visual Studio generated using Alexander Teinum's "Dainty for Visual Studio", saved with "Visual Studio Color Theme Designer" and tweaked to closer match Binaryify's "One Dark Pro" theme for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=adrianwilczynski.one-dark-pro
MIT License
92 stars 24 forks source link

feat: add support for visual studio 2022 preview 1 #18

Closed MrCSharp22 closed 3 years ago

MrCSharp22 commented 3 years ago

A simple target version range update to allow Dark One Pro to run under Visual Studio 2022 Preview 1

AdrianWilczynski commented 3 years ago

Thanks for the PR. I'll try to test and push it out soon.

AlexMax commented 3 years ago

Looking forward to it. Avid user of your theme.

pwuersch commented 3 years ago

Would be awesome to have this in the marketplace for the 2022 edition. Really like your theme.

AdrianWilczynski commented 3 years ago

Hey, thanks again for the pull request, and sorry that it took me so long to act on it. Visual Studio 2022 should be supported now.

I wasn't familiar with the process of porting extensions to Visual Studio 2022, and I didn't feel qualified to review this PR. I wanted to go through the steps myself to understand it better. Since I let this PR go a bit stale (we're at preview 4 now), I've decided to commit the changes instead of merging it. Your PR was really helpful as a reference.

pwuersch commented 3 years ago

Nice, thanks @AdrianWilczynski for adding the extension to the new Visual Studio. Finally I can get my old familiar IDE look again 😄

MrCSharp22 commented 3 years ago

Thanks @AdrianWilczynski. Glad I could help with this :)