search

AdrianWilczynski / OneDarkPro

"One Dark Pro" theme for Visual Studio generated using Alexander Teinum's "Dainty for Visual Studio", saved with "Visual Studio Color Theme Designer" and tweaked to closer match Binaryify's "One Dark Pro" theme for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=adrianwilczynski.one-dark-pro
MIT License
92 stars 24 forks source link

Color issues for html attribute name and razor component in VS 2022 #24

Closed TanvirArjel closed 2 years ago

TanvirArjel commented 3 years ago

For HTML attribute name, the current color is pure red which seems odd and feels like error as follows:

InkedCapture_LI

Suggestion: You can choose Magenta for the HTML attribute name and it will shows as follows:

image

Now the current color (Purple) for the razor component is almost unreadable as follows:

Inkedrazor_LI

Suggestion: Please choose the following color for razor component

  1. Razor Component Element - Olive
  2. Razor Component Attribute- Magenta
  3. Razor Tag Helper Element - Olive
  4. Razor Tag Helper Attribute - Magenta
  5. Razor Directive (foreground) - Yellow
  6. Razor Directive (background) - Automatic (Background of the text editor)

Then it will look like as follows:

image

image

AdrianWilczynski commented 3 years ago

Hi, thanks for the report. Something must have changed between Visual Studio 2019 and 2022 because it shouldn't look like that.

I don't know if it's going to be easy to fix because Visual Studio Color Theme Designer isn't yet supported on Visual Studio 2022.

image

TanvirArjel commented 3 years ago

@AdrianWilczynski It looks like html attribute and razor component colors are fine in Visual Stuido 2019.

Hope you will find a way to fix this for Visual Studio 2022.

Thanks in advance.

AdrianWilczynski commented 3 years ago

It's not a fix, but it seems like you can override invalid default values through settings.

image

TanvirArjel commented 3 years ago

I have already done this. 😀

AdrianWilczynski commented 3 years ago

Makes sense. It didn't click for me that you had to do something like that to make the screenshots 😅.

TanvirArjel commented 3 years ago

@AdrianWilczynski

Hi, thanks for the report. Something must have changed between Visual Studio 2019 and 2022 because it shouldn't look like that.

I don't know if it's going to be easy to fix because Visual Studio Color Theme Designer isn't yet supported on Visual Studio 2022.

Did you try to reach out to the Visual Studio 2022 team by submitting an issue regarding the above things?

jeffward01 commented 3 years ago

Does anyone else have this issue? I want to use this theme for my Blazor Development, but afraid of these color issues

AdrianWilczynski commented 2 years ago

Fixed by: https://github.com/AdrianWilczynski/OneDarkPro/commit/e0dd92c9595edaac682f0ffac91539f82e6c5209 & https://github.com/AdrianWilczynski/OneDarkPro/commit/faac5ea49edf24969385945fc81987e3a335a4cc