search

AdrianWilczynski / OneDarkPro

"One Dark Pro" theme for Visual Studio generated using Alexander Teinum's "Dainty for Visual Studio", saved with "Visual Studio Color Theme Designer" and tweaked to closer match Binaryify's "One Dark Pro" theme for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=adrianwilczynski.one-dark-pro
MIT License
92 stars 24 forks source link

Problem with dark theme in VS2022 Version 17.8.0 Preview 5.0 #36

Open Rufistofeles opened 1 year ago

Rufistofeles commented 1 year ago

When my VS2022 updated to Version 17.8.0 Preview 5.0, the dark theme isn't working anymore, it only shows light color menu and dark color text space.

image

TwentyFourMinutes commented 1 year ago

Same issue over here. FYI: https://developercommunity.visualstudio.com/t/Visual-Studio-2022-Preview-50-Theme-bug/10506590

0x5bfa commented 7 months ago

I made it worked.

There are some dedicated vstheme categories.

image

TwentyFourMinutes commented 7 months ago

@0x5bfa That looks great! It would be awesome if you could share the adjustments you have made 🎉

0x5bfa commented 7 months ago

Sure. While I'm about to forget what those elements mean, here it is.

This theme below is not for OneDarkPro but GitHub Dark, and so you have to make some color changes to make it look better.

    <Category Name="Shell" GUID="{73708ded-2d56-4aad-b8eb-73b20d3f4bff}">
      <Color Name="AccentFillDefault">
        <Background Type="CT_RAW" Source="FF005CC5" />
      </Color>
      <Color Name="SolidBackgroundFillTertiary">
        <Background Type="CT_RAW" Source="FF24292E" />
      </Color>
    </Category>
    <Category Name="ShellInternal" GUID="{5af241b7-5627-4d12-bfb1-2b67d11127d7}">
      <Color Name="EnvironmentBackground">
        <Background Type="CT_RAW" Source="FF1F2428" />
      </Color>
      <Color Name="EnvironmentBadge">
        <Background Type="CT_RAW" Source="FF176F2C" />
      </Color>
      <Color Name="EnvironmentBorder">
        <Background Type="CT_RAW" Source="FF005CC5" />
      </Color>
      <Color Name="EnvironmentIndicator">
        <Background Type="CT_RAW" Source="FF1B1F23" />
      </Color>
      <Color Name="EnvironmentLogo">
        <Background Type="CT_RAW" Source="FF005CC5" />
      </Color>
      <Color Name="EnvironmentLayeredBackground">
        <Background Type="CT_RAW" Source="4D000000" />
      </Color>
    </Category>

PS, this won't affect on existing theme colors because those categories are newly introduced and VS2022 17.7 or earlier won't recognize. It means that you just have to append those categories above to the existing vstheme file.

TwentyFourMinutes commented 7 months ago

@0x5bfa Thank you very much for that, I'll test it out soon.