search

AdrienTD / c47edit

Hitman C47 Scene Editor
GNU General Public License v3.0
27 stars 8 forks source link

Fix building c47edit using MinGW on Linux #15

Open madebr opened 2 months ago

madebr commented 2 months ago

These patches fix building c47edit on Linux using a MinGW toolchain.

AdrienTD commented 2 months ago

Thanks for the PR! It's indeed useful to support other compilers, and also make it compile on Linux (and run with Wine), because you never know how Windows will become these days...

But at the same time I would have to be more careful to not introduce some compile errors that would only trigger GCC/Clang but not VC++ :)

I will review it, there's some things I need to ask.

Aztec2012 commented 1 month ago

AppVeyor build failed

madebr commented 1 month ago 
error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8'

Since it is happening in libfmt, I suppose this has nothing to do with this pr but with the dependency. I'll apply a patch similar to this one to the vcxproj

madebr commented 1 month ago

With these 2 last commits, the only error remaining for targeting Linux are the windows.h includes (and its use of the win api).

If https://github.com/0danny/re47 ever gets somewhere, it should be easy to port everything to a platform agnostic toolkit, such as SDL.