How to stop adding new short grass in spring?

tsingyayin commented 4 months ago

Describe the bug

My server players complained to me that they got too many short grass. However, I noticed that in blocks.yml, I have set the generateCustomGrass of the corresponding world to false. It seems that the configuration does not work.

I can confirm that the world name is correct.

I remember this problem occurred in the plugin from the day I bought it (about 4 months ago).

How to reproduce

Open blocks.yml
Set worlds.world.generateCustomGrass to false
Spring will still have short grass to be generated.

Screenshots / Videos

There is nothing to show except the short grass everywhere

Server Log

No response

Ynverxe commented 3 months ago

Photos?

tsingyayin commented 3 months ago

2024-08-15_21 27 16 Short grass everywhere

Ynverxe commented 3 months ago

Thank you! So I'll need more information. Please provide me your AS configuration files and the latest log of your server(serverDir/logs/latest.log).

tsingyayin commented 3 months ago

AdvancedSeasons.zip I'm very sorry, because our server logs also record the chats on our external community platform, they can't be pushed to the public until I handle them. If you have to, I will try my best to write a small script to handle it within 24 hours and send it here

tsingyayin commented 3 months ago

Plugin version 1.3.14, and just as what I have pointed, it has occurred at least 4 months

tsingyayin commented 3 months ago

Personally, I don't think it's worth noticing. At least as far as today's log is concerned, I only saw a log of SpigotLibLoader after starting the server.

However, it should be noted that AdvancedSeasons does occasionally destroy my MSPT recently, and then I usually receive such Exception reports:

[23:02:57] [Craft Scheduler Thread - 10193 - AdvancedSeasons/WARN]: [AdvancedSeasons] Plugin AdvancedSeasons v1.3.14 generated an exception while executing task 464
java.lang.IllegalArgumentException: y out of range (expected -64-320, got -69)
    at com.google.common.base.Preconditions.checkArgument(Preconditions.java:463) ~[guava-32.1.2-jre.jar:?]
    at org.bukkit.craftbukkit.CraftChunk.validateChunkCoordinates(CraftChunk.java:432) ~[purpur-1.21.jar:1.21-2280-930003b]
    at org.bukkit.craftbukkit.CraftChunkSnapshot.validateChunkCoordinates(CraftChunkSnapshot.java:188) ~[purpur-1.21.jar:1.21-2280-930003b]
    at org.bukkit.craftbukkit.CraftChunkSnapshot.getBlockType(CraftChunkSnapshot.java:100) ~[purpur-1.21.jar:1.21-2280-930003b]
    at AdvancedSeasons-1.3.14.jar/net.advancedplugins.seasons.visuals.type.AbstractFallingLeafVisual.createFallingSnowFromLeaves(AbstractFallingLeafVisual.java:80) ~[AdvancedSeasons-1.3.14.jar:?]
    at AdvancedSeasons-1.3.14.jar/net.advancedplugins.seasons.visuals.type.AbstractFallingLeafVisual.tick(AbstractFallingLeafVisual.java:22) ~[AdvancedSeasons-1.3.14.jar:?]
    at java.base/java.util.HashMap$KeySet.forEach(HashMap.java:1016) ~[?:?]
    at AdvancedSeasons-1.3.14.jar/net.advancedplugins.seasons.visuals.VisualsHandler.lambda$new$0(VisualsHandler.java:28) ~[AdvancedSeasons-1.3.14.jar:?]
    at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:86) ~[purpur-1.21.jar:1.21-2280-930003b]
    at org.bukkit.craftbukkit.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[purpur-1.21.jar:1.21-2280-930003b]
    at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[purpur-1.21.jar:?]
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
    at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Once such reports appear, they usually appear hundreds of times in succession： Pay attention to the line number on the left. It's really crazy

Ynverxe commented 3 months ago

I usually receive such Exception reports:

This should be fixed on the next release.

tsingyayin commented 3 months ago

So what's new about the bug of short grass

Ynverxe commented 3 months ago

So what's new about the bug of short grass

I'm still working on that.

Ynverxe commented 3 months ago

Seems that the grass accumulation is caused when winter changes to another season.

When this happens AS generates grass in places where there is snow. When this happens many times, the number of grass is increasing.

tsingyayin commented 1 month ago

Is there any plan to further promote or completely solve this issue in the near future ? (before the end of the year)

AdvancedPlugins / Seasons