AdvancedXRay / Auto-Clicker

Quick and dirty Auto Clicker mod for Fabric(mc)
https://www.curseforge.com/minecraft/mc-mods/auto-clicker-fabric
MIT License
39 stars 25 forks source link

[Bug] Auto clicker stops when inventory is opened. #12

Open Cloudate9 opened 3 years ago

Cloudate9 commented 3 years ago

Describe the bug When auto clicker is on right click mode, and spam mode off, auto clicker stops if a minecraft inventory (including GUI) is opened.

To Reproduce Steps to reproduce the behavior:

  1. Enable right click mode, spam false, and mob mode false
  2. Enable the auto clicker
  3. Open a gui or inventory (e.g. survival inventory, Auto-Clicker-Fabric configuration menu, pause menu)
  4. Right click should stop, and not continue when the gui or inventory is closed.

Expected behavior Right click should continue to be held, even when gui or inventory is opened.

Screenshots Screenshots are not applicable.

Minecraft Enviorment

Additional context Expected behaviour happens when mob mode is true, where mob continue to be attacked even when I open a gui/minecraft inventory.

Feel free to reach out for additional questions! Love the work!

MichaelHillcox commented 3 years ago

Thanks for the kind comments, I've had someone else say the same thing, there is a pretty big design change that would be needed to support this kind of feature, my main question though is what use you'd have for it? As in, when do you need it to keep clicking with an inventory open?

Cloudate9 commented 3 years ago

Oops, made a big blunder. For everytime I say right click in the above common, I actually mean left click. Sorry for the confusion.

I think it's less of when, but rather more of a QOL feature. Cause in Vanilla, we already have an option to hold left click, but can't do so anything else.

I brought it up mainly cause of the inconsistancy between mob mode and non mob mode, and thought you may be unaware that this is happening.

GitWumm commented 1 year ago

I noticed this as well and for me it's actually a big deal. I use the auto-left click to kill mobs and the hold-right (as described in the originial issue) to consume food. This is especially important when receiving damage at farms, which means I can only use these farms while the minecraft window is in focus. As soon as I switch tabs (e.g. browser) the pause gui will open and I no longer consume food, which eventually leads to me dying at my farm. This just leaves afk-ing overnight with minecraft in the active window.

Would love to see this fixed, since I bet there are other cases where this bug is annoying.

Edaurd commented 10 months ago

This seems to not only hapening to when a inventory is opened but also whenever anything is opened, including chat, i have used another mod in the past to achive this and i always opened chat to still have a clear vision of my game but not having to worry the game suddenly grabbing my mouse when i accidentally click on it

MichaelHillcox commented 10 months ago

I noticed this as well and for me it's actually a big deal. I use the auto-left click to kill mobs and the hold-right (as described in the originial issue) to consume food. This is especially important when receiving damage at farms, which means I can only use these farms while the minecraft window is in focus. As soon as I switch tabs (e.g. browser) the pause gui will open and I no longer consume food, which eventually leads to me dying at my farm. This just leaves afk-ing overnight with minecraft in the active window.

Would love to see this fixed, since I bet there are other cases where this bug is annoying.

You can disable this behaviour in minecraft. It's one of the f3 + q options. Something like disable pause menu on focus loss.

GitWumm commented 10 months ago

I noticed this as well and for me it's actually a big deal. I use the auto-left click to kill mobs and the hold-right (as described in the originial issue) to consume food. This is especially important when receiving damage at farms, which means I can only use these farms while the minecraft window is in focus. As soon as I switch tabs (e.g. browser) the pause gui will open and I no longer consume food, which eventually leads to me dying at my farm. This just leaves afk-ing overnight with minecraft in the active window. Would love to see this fixed, since I bet there are other cases where this bug is annoying.

You can disable this behaviour in minecraft. It's one of the f3 + q options. Something like disable pause menu on focus loss.

Omg, you're right, I didn't know about this. This solves the issue for me, thanks!

Edaurd commented 10 months ago

That's not what I mean, when you do that and accidentally click on the game it takes over your mouse, the game is not paused, if you have chat open it prevents your mouse from snapping on to the game requiring you to alt tab out again