AdvancedXRay / Auto-Clicker

Quick and dirty Auto Clicker mod for Fabric(mc)
https://www.curseforge.com/minecraft/mc-mods/auto-clicker-fabric
MIT License
39 stars 25 forks source link

Displayed speed slider value is one off from set value when reopening options menu #28

Closed jmolloy19 closed 1 year ago

jmolloy19 commented 1 year ago

Describe the bug When opening the options menu and using the slider to set a tick speed, the text within the slider will display/confirm a selected tick speed. When closing the options menu and re-opening, the displayed tick speed within the slider is one off from previously displayed/set tick speed.

To Reproduce Steps to reproduce the behavior:

  1. Open options menu, and set any speed slider to 35 ticks as displayed set value.
  2. Close options menu, and reopen options menu to view speed slider displaying a value of 34 ticks.

Expected behavior Expect the displayed set value in slider to persist on closing and re-opening options menu.

Screenshots Setting all speed sliders to 35 ticks

image

Closing and reopening options menu

image

Minecraft Enviorment

Additional context The issue seems to happen only for certain odd integer values, and when it does happen, the error is consistently one less than actual selected value.

MichaelHillcox commented 1 year ago

Merged into 1.19.3 and 1.19.4, let me know if you want it to target any other versions