search

Adyen / adyen-magento2-express-checkout

Adyen Magento 2 Express Checkout Module
MIT License
8 stars 2 forks source link

Improves Apple pay errors #69

Open dimitriBouteille opened 6 months ago

dimitriBouteille commented 6 months ago

Summary

This MR improves error display with Apple Pay checkout. The user can easily change the error handling thanks to the new functions.

onShippingContactSelect

The addressUnserviceable error is displayed by ApplePay if not shipping method.

The code that indicates that the merchant can’t provide service to the shipping address (for example, can’t deliver to a P.O. Box).

281679485-bbcd4548-8dad-406e-86d3-d05c10896de7

startPlaceOrder

The explicit placeOrder error orYour payment failed, Please try again later is displayed in the cart if an error occurs during the placeOrder.

IMG_20231213_172507 (1)

Resolve #59

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

candemiralp commented 6 months ago

Hello @dimitriBouteille,

Thank you for your contribution. We will review this PR and merge it afterwards.

Best Regards, Can

dimitriBouteille commented 2 months ago

Hi @RokPopov & @candemiralp

Can you look this MR in order to maybe include it in the next release.

Thanks !