Adyen / adyen-web

Adyen Web Drop-in and Components
https://docs.adyen.com/online-payments
MIT License
187 stars 132 forks source link

`showPayButton` not working for stored ACH #2554

Closed jaredtbates closed 5 months ago

jaredtbates commented 9 months ago

Describe the bug Hi there! We are using the Adyen drop-in and have an external button to trigger payment. However, the showPayButton property is not working when showing stored ACH payment methods. It seems to be showing the "Continue to ..." button no matter what we pass in.

To Reproduce

Here's a rudimentary code example:

AdyenCheckout({
  paymentMethodsResponse: {
    paymentMethods: [
      {
        brand: null,
        brands: null,
        configuration: null,
        fundingSource: null,
        group: null,
        inputDetails: null,
        issuers: null,
        name: 'ACH Direct Debit',
        type: 'ach',
      },
    ],
    storedPaymentMethods: [
      {
        bankAccountNumber: '011000138',
        bankLocationId: '011000138',
        brand: null,
        expiryMonth: null,
        expiryYear: null,
        holderName: null,
        iban: null,
        id: 'ASDFASDFASDFASDF',
        label: null,
        lastFour: null,
        name: 'ACH Direct Debit',
        networkTxReference: null,
        ownerName: 'Jared Bates',
        shopperEmail: null,
        supportedRecurringProcessingModels: [
          'CardOnFile',
          'Subscription',
          'UnscheduledCardOnFile',
        ],
        supportedShopperInteractions: ['Ecommerce', 'ContAuth'],
        type: 'ach',
      },
    ],
  } as any,
  showPayButton: false,
}).then((checkout) => checkout.create('dropin').mount('#dropin-container'));

Expected behavior I expect the showPayButton property to hide the "Continue to ..." button in the drop-in.

Screenshots

image

Desktop (please complete the following information):

m1aw commented 7 months ago

@jaredtbates this indeed seems to be an issue. Since it regards a few more payment methods we are going to issue a proper fix. We will keep you updated.

jaredtbates commented 6 months ago

Hi @m1aw! Just curious, is there a plan to fix this in the next few weeks possibly? Thanks!

m1aw commented 5 months ago

I have created a fix for this. Probably shipping this next week.

ribeiroguilherme commented 5 months ago

Hi @jaredtbates - we made a release 5.66.0 which should fix this issue. Could you please verify that?

jaredtbates commented 5 months ago

Thanks @ribeiroguilherme, sorry for the delay. This works great for us!